hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "HowToContribute" by TomWhite
Date Thu, 25 Jun 2009 21:16:27 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The following page has been changed by TomWhite:
http://wiki.apache.org/hadoop/HowToContribute

The comment on the change is:
Added links to review queue Jira filters

------------------------------------------------------------------------------
  
  Finally, patches should be ''attached'' to an issue report in [http://issues.apache.org/jira/browse/HADOOP
Jira] via the '''Attach File''' link on the issue's Jira. Please add a comment that asks for
a code review following our [:CodeReviewChecklist: code review checklist]. Please note that
the attachment should be granted license to ASF for inclusion in ASF works (as per the [http://www.apache.org/licenses/LICENSE-2.0
Apache License] ยง5). 
  
- When you believe that your patch is ready to be committed, select the '''Submit Patch'''
link on the issue's Jira.  Submitted patches will be automatically tested against "trunk"
by [http://hudson.zones.apache.org/hudson/ Hudson], the project's continuous integration engine.
 Upon test completion, Hudson will add a success ("+1") message or failure ("-1") to your
issue report in Jira.  If your issue contains multiple patch versions, Hudson tests the last
patch uploaded.
+ When you believe that your patch is ready to be committed, select the '''Submit Patch'''
link on the issue's Jira.  Submitted patches will be automatically tested against "trunk"
by [http://hudson.zones.apache.org/hudson/view/Hadoop/ Hudson], the project's continuous integration
engine.  Upon test completion, Hudson will add a success ("+1") message or failure ("-1")
to your issue report in Jira.  If your issue contains multiple patch versions, Hudson tests
the last patch uploaded.
  
  Folks should run {{{ant clean test javadoc checkstyle}}} before selecting '''Submit Patch'''.
 Tests should all pass.  Javadoc should report '''no''' warnings or errors. Checkstyle's error
count should not exceed that listed at [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/lastSuccessfulBuild/artifact/trunk/build/test/checkstyle-errors.html
Checkstyle Errors]  Hudson's tests are meant to double-check things, and not be used as a
primary patch tester, which would create too much noise on the mailing list and in Jira. 
Submitting patches that fail Hudson testing is frowned on, (unless the failure is not actually
due to the patch).
  
@@ -179, +179 @@

  
  Should your patch receive a "-1" from the Hudson testing, select the '''Resume Progress'''
on the issue's Jira, upload a new patch with necessary fixes, and then select the '''Submit
Patch''' link again.
  
- Committers: for non-trivial changes, it is best to get another committer to review your
patches before commit.  Use '''Submit Patch''' link like other contributors, and then wait
for a "+1" from another committer before committing.  Please also try to frequently review
things in the patch queue.
+ Committers: for non-trivial changes, it is best to get another committer to review your
patches before commit.  Use '''Submit Patch''' link like other contributors, and then wait
for a "+1" from another committer before committing.  Please also try to frequently review
things in the patch queues:
+  * [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12311124
Hadoop Common Review Queue]
+  * [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12313301
Hadoop HDFS Review Queue]
+  * [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12313302
Hadoop MapReduce Review Queue]
  
  == Jira Guidelines ==
  

Mime
View raw message