hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject svn commit: r779306 - /hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java
Date Wed, 27 May 2009 20:47:47 GMT
Author: stevel
Date: Wed May 27 20:47:47 2009
New Revision: 779306

URL: http://svn.apache.org/viewvc?rev=779306&view=rev
Log:
HADOOP-3628 IDE flagging problems

Modified:
    hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java

Modified: hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java
URL: http://svn.apache.org/viewvc/hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java?rev=779306&r1=779305&r2=779306&view=diff
==============================================================================
--- hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java (original)
+++ hadoop/core/branches/HADOOP-3628-2/src/core/org/apache/hadoop/util/Service.java Wed May
27 20:47:47 2009
@@ -199,7 +199,7 @@
    * {@link ServiceState#FAILED} and {@link ServiceState#CLOSED}
    * to be valid, so it is OK to ping a
    * component that is still starting up. However, in such situations, the inner
-   * ping health tests are skipped, because they are generally irrelvant.
+   * ping health tests are skipped, because they are generally irrelevant.
    *
    * Subclasses should not normally override this method, but instead override
    * {@link #innerPing(ServiceStatus)} with extra health checks that will only
@@ -264,6 +264,7 @@
    * @param thrown the exception to forward
    * @return an IOException representing or containing the forwarded exception
    */
+  @SuppressWarnings({"ThrowableInstanceNeverThrown"})
   protected IOException forwardAsIOException(Throwable thrown) {
     IOException newException;
     if(thrown instanceof IOException) {
@@ -691,7 +692,6 @@
    * Terminate a service or other closeable that is not null
    *
    * @param closeable the object to close
-   * @throws IOException any exception during the close operation
    */
   public static void close(Closeable closeable) {
     if (closeable != null) {
@@ -925,6 +925,10 @@
       }
     }
 
+    /**
+     * Get the list of throwables. This may be null.
+     * @return A list of throwables or null
+     */
     public List<Throwable> getThrowables() {
       return throwables;
     }
@@ -962,7 +966,7 @@
     }
 
     /**
-     * Get the timestamp of the last state change
+     * Get the date of the last state change
      * @return when the service state last changed
      */
     public Date getLastStateChange() {



Mime
View raw message