hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject svn commit: r757849 - in /hadoop/core/trunk: CHANGES.txt src/mapred/org/apache/hadoop/mapred/JobTracker.java
Date Tue, 24 Mar 2009 15:32:19 GMT
Author: ddas
Date: Tue Mar 24 15:32:15 2009
New Revision: 757849

URL: http://svn.apache.org/viewvc?rev=757849&view=rev
Log:
HADOOP-5231. Clones the TaskStatus before passing it to the JobInProgress. Contributed by
Amareshwari Sriramadasu.

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=757849&r1=757848&r2=757849&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Tue Mar 24 15:32:15 2009
@@ -1147,6 +1147,9 @@
     HADOOP-5554. DataNodeCluster and CreateEditsLog should create blocks with
     the same generation stamp value. (hairong via szetszwo)
 
+    HADOOP-5231. Clones the TaskStatus before passing it to the JobInProgress.
+    (Amareshwari Sriramadasu via ddas)
+
 Release 0.19.1 - 2009-02-23 
 
   IMPROVEMENTS

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java?rev=757849&r1=757848&r2=757849&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java Tue Mar 24 15:32:15
2009
@@ -3250,7 +3250,11 @@
         
         // Update the job and inform the listeners if necessary
         JobStatus prevStatus = (JobStatus)job.getStatus().clone();
-        job.updateTaskStatus(tip, report);
+        // Clone TaskStatus object here, because JobInProgress
+        // or TaskInProgress can modify this object and
+        // the changes should not get reflected in TaskTrackerStatus.
+        // An old TaskTrackerStatus is used later in countMapTasks, etc.
+        job.updateTaskStatus(tip, (TaskStatus)report.clone());
         JobStatus newStatus = (JobStatus)job.getStatus().clone();
         
         // Update the listeners if an incomplete job completes



Mime
View raw message