hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acmur...@apache.org
Subject svn commit: r696846 - in /hadoop/core/trunk: ./ src/mapred/org/apache/hadoop/mapred/
Date Thu, 18 Sep 2008 23:04:26 GMT
Author: acmurthy
Date: Thu Sep 18 16:04:25 2008
New Revision: 696846

URL: http://svn.apache.org/viewvc?rev=696846&view=rev
Log:
HADOOP-4194. Added the JobConf and JobID to job-related methods in obTrackerInstrumentation
for better metrics. Contributed by Mac Yang.

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobInProgress.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerMetricsInst.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=696846&r1=696845&r2=696846&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Thu Sep 18 16:04:25 2008
@@ -362,6 +362,9 @@
     HADOOP-4083. Changed the configuration attribute queue.name to
     mapred.job.queue.name. (Hemanth Yamijala via acmurthy) 
 
+    HADOOP-4194. Added the JobConf and JobID to job-related methods in
+    JobTrackerInstrumentation for better metrics. (Mac Yang via acmurthy) 
+
   OPTIMIZATIONS
 
     HADOOP-3556. Removed lock contention in MD5Hash by changing the 

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobInProgress.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobInProgress.java?rev=696846&r1=696845&r2=696846&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobInProgress.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobInProgress.java Thu Sep 18 16:04:25
2008
@@ -1738,7 +1738,7 @@
       // might try to finalize
       garbageCollect();
       
-      metrics.completeJob();
+      metrics.completeJob(this.conf, this.status.getJobID());
     }
   }
   

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java?rev=696846&r1=696845&r2=696846&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java Thu Sep 18 16:04:25
2008
@@ -2184,7 +2184,7 @@
         }
       }
     }
-    myInstrumentation.submitJob();
+    myInstrumentation.submitJob(this.conf, jobId);
     return job.getStatus();
   }
 

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java?rev=696846&r1=696845&r2=696846&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java Thu
Sep 18 16:04:25 2008
@@ -39,10 +39,10 @@
   public void completeReduce(TaskAttemptID taskAttemptID)
   {  }
   
-  public void submitJob() 
+  public void submitJob(JobConf conf, JobID id) 
   { }
     
-  public void completeJob() 
+  public void completeJob(JobConf conf, JobID id) 
   { }
 
-}
\ No newline at end of file
+}

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerMetricsInst.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerMetricsInst.java?rev=696846&r1=696845&r2=696846&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerMetricsInst.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerMetricsInst.java Thu Sep
18 16:04:25 2008
@@ -89,11 +89,11 @@
     ++numReduceTasksCompleted;
   }
     
-  public synchronized void submitJob() {
+  public synchronized void submitJob(JobConf conf, JobID id) {
     ++numJobsSubmitted;
   }
     
-  public synchronized void completeJob() {
+  public synchronized void completeJob(JobConf conf, JobID id) {
     ++numJobsCompleted;
   }
-}
\ No newline at end of file
+}



Mime
View raw message