hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "HowToContribute" by DougCutting
Date Fri, 20 Jun 2008 20:58:01 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The following page has been changed by DougCutting:
http://wiki.apache.org/hadoop/HowToContribute

The comment on the change is:
add note about renaming files

------------------------------------------------------------------------------
  In order to create a patch, type:
  
  {{{
- svn diff > myBeautifulPatch.patch
+ svn diff > HADOOP-1234.patch
  }}}
  
- This will report all modifications done on Hadoop sources on your local disk and save them
into the ''myBeautifulPath.patch'' file.  Read the patch file.  
+ This will report all modifications done on Hadoop sources on your local disk and save them
into the ''HADOOP-1234.patch'' file.  Read the patch file.  
  Make sure it includes ONLY the modifications required to fix a single issue.
  
  Please do not:
@@ -102, +102 @@

   * try to adhere to the coding style of files you edit;
   * comment code whose function or rationale is not obvious;
   * update documentation (e.g., ''package.html'' files, this wiki, etc.)
+ 
+ If you need to rename files in your patch:
+  1. Write a shell script that uses 'svn mv' to rename the original files.
+  1. Edit files as needed (e.g., to change package names).
+  1. Create a patch file with 'svn diff --no-diff-deleted --notice-ancestry'.
+  1. Submit both the shell script and the patch file.
+ This way other developers can preview your change by running the script and then applying
the patch.
  
  ==== Testing your patch ====
  

Mime
View raw message