From core-commits-return-4692-apmail-hadoop-core-commits-archive=hadoop.apache.org@hadoop.apache.org Fri Apr 25 19:59:00 2008 Return-Path: Delivered-To: apmail-hadoop-core-commits-archive@www.apache.org Received: (qmail 67177 invoked from network); 25 Apr 2008 19:59:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Apr 2008 19:59:00 -0000 Received: (qmail 71599 invoked by uid 500); 25 Apr 2008 19:58:51 -0000 Delivered-To: apmail-hadoop-core-commits-archive@hadoop.apache.org Received: (qmail 71513 invoked by uid 500); 25 Apr 2008 19:58:51 -0000 Mailing-List: contact core-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-commits@hadoop.apache.org Received: (qmail 71460 invoked by uid 99); 25 Apr 2008 19:58:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2008 12:58:50 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2008 19:58:15 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 41B761A9832; Fri, 25 Apr 2008 12:58:28 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r651691 - in /hadoop/core/trunk: CHANGES.txt src/java/org/apache/hadoop/ipc/RPC.java Date: Fri, 25 Apr 2008 19:58:22 -0000 To: core-commits@hadoop.apache.org From: cdouglas@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080425195828.41B761A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: cdouglas Date: Fri Apr 25 12:58:10 2008 New Revision: 651691 URL: http://svn.apache.org/viewvc?rev=651691&view=rev Log: HADOOP-3313. Avoid unnecessary calls to System.currentTimeMillis in RPC::Invoker. Modified: hadoop/core/trunk/CHANGES.txt hadoop/core/trunk/src/java/org/apache/hadoop/ipc/RPC.java Modified: hadoop/core/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=651691&r1=651690&r2=651691&view=diff ============================================================================== --- hadoop/core/trunk/CHANGES.txt (original) +++ hadoop/core/trunk/CHANGES.txt Fri Apr 25 12:58:10 2008 @@ -88,6 +88,9 @@ HADOOP-2793. Fix broken links for worst performing shuffle tasks in the job history page. (Amareshwari Sriramadasu via ddas) + HADOOP-3313. Avoid unnecessary calls to System.currentTimeMillis + in RPC::Invoker. (cdouglas) + Release 0.17.0 - Unreleased INCOMPATIBLE CHANGES Modified: hadoop/core/trunk/src/java/org/apache/hadoop/ipc/RPC.java URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/ipc/RPC.java?rev=651691&r1=651690&r2=651691&view=diff ============================================================================== --- hadoop/core/trunk/src/java/org/apache/hadoop/ipc/RPC.java (original) +++ hadoop/core/trunk/src/java/org/apache/hadoop/ipc/RPC.java Fri Apr 25 12:58:10 2008 @@ -208,11 +208,17 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { - long startTime = System.currentTimeMillis(); + final boolean logDebug = LOG.isDebugEnabled(); + long startTime = 0; + if (logDebug) { + startTime = System.currentTimeMillis(); + } ObjectWritable value = (ObjectWritable) client.call(new Invocation(method, args), address, ticket); - long callTime = System.currentTimeMillis() - startTime; - LOG.debug("Call: " + method.getName() + " " + callTime); + if (logDebug) { + long callTime = System.currentTimeMillis() - startTime; + LOG.debug("Call: " + method.getName() + " " + callTime); + } return value.get(); }