From core-commits-return-4499-apmail-hadoop-core-commits-archive=hadoop.apache.org@hadoop.apache.org Thu Apr 03 00:35:47 2008 Return-Path: Delivered-To: apmail-hadoop-core-commits-archive@www.apache.org Received: (qmail 86845 invoked from network); 3 Apr 2008 00:35:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Apr 2008 00:35:47 -0000 Received: (qmail 51942 invoked by uid 500); 3 Apr 2008 00:35:47 -0000 Delivered-To: apmail-hadoop-core-commits-archive@hadoop.apache.org Received: (qmail 51914 invoked by uid 500); 3 Apr 2008 00:35:47 -0000 Mailing-List: contact core-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-commits@hadoop.apache.org Received: (qmail 51904 invoked by uid 99); 3 Apr 2008 00:35:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2008 17:35:47 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.130] (HELO eos.apache.org) (140.211.11.130) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2008 00:35:04 +0000 Received: from eos.apache.org (localhost [127.0.0.1]) by eos.apache.org (Postfix) with ESMTP id DD809D2F9 for ; Thu, 3 Apr 2008 00:35:23 +0000 (GMT) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Apache Wiki To: core-commits@hadoop.apache.org Date: Thu, 03 Apr 2008 00:35:23 -0000 Message-ID: <20080403003523.20560.49547@eos.apache.org> Subject: [Hadoop Wiki] Update of "CodeReviewChecklist" by NigelDaley X-Virus-Checked: Checked by ClamAV on apache.org Dear Wiki user, You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification. The following page has been changed by NigelDaley: http://wiki.apache.org/hadoop/CodeReviewChecklist The comment on the change is: Added items for the new Jira fields: Incompatible change, Reviewed, Release Note ------------------------------------------------------------------------------ = Code Review Checklist = - Here is a list of things to check during code reviews. + Here is a list of things to check during code reviews. Once the review is complete (which means all suggestions from previous reviews have been satisfactorily incorporated and you believe the patch is ready to commit) then please set the '''Reviewed''' flag on the issue's Jira. == Coding Style == @@ -49, +49 @@ == Tests == - * unit tests exist for bug fixes and new features, or a rationale is given in Jira for why there is no test + * '''unit tests exist for bug fixes and new features, or a rationale is given in Jira for why there is no test''' * unit tests do not write any temporary files to {{{/tmp}}} (instead, the tests should write to the location specified by the {{{test.build.data}}} system property) * {{{org.apache.hadoop.dfs.MiniDFSCluster}}} and {{{org.apache.hadoop.mapred.MiniMRCluster}}} are used to start servers as needed (servers are not directly instantiated) + == Jira == + + * the '''Incompatible change''' flag on the issue's Jira is set appropriately for this patch + * for incompatible changes, major features/improvements, and other release notable issues, the '''Release Note''' field has a sufficient comment +