hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "CodeReviewChecklist" by NigelDaley
Date Thu, 03 Apr 2008 00:35:23 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The following page has been changed by NigelDaley:
http://wiki.apache.org/hadoop/CodeReviewChecklist

The comment on the change is:
Added items for the new Jira fields: Incompatible change, Reviewed, Release Note

------------------------------------------------------------------------------
  = Code Review Checklist =
  
- Here is a list of things to check during code reviews.
+ Here is a list of things to check during code reviews.  Once the review is complete (which
means all suggestions from previous reviews have been satisfactorily incorporated and you
believe the patch is ready to commit) then please set the '''Reviewed''' flag on the issue's
Jira.
  
  == Coding Style ==
  
@@ -49, +49 @@

  
  == Tests ==
  
-  * unit tests exist for bug fixes and new features, or a rationale is given in Jira for
why there is no test
+  * '''unit tests exist for bug fixes and new features, or a rationale is given in Jira for
why there is no test'''
   * unit tests do not write any temporary files to {{{/tmp}}} (instead, the tests should
write to the location specified by the {{{test.build.data}}} system property)
   * {{{org.apache.hadoop.dfs.MiniDFSCluster}}} and {{{org.apache.hadoop.mapred.MiniMRCluster}}}
are used to start servers as needed (servers are not directly instantiated)
  
+ == Jira ==
+ 
+  * the '''Incompatible change''' flag on the issue's Jira is set appropriately for this
patch
+  * for incompatible changes, major features/improvements, and other release notable issues,
the '''Release Note''' field has a sufficient comment
+ 

Mime
View raw message