hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "Hbase/HowToCommit" by JimKellerman
Date Sat, 09 Feb 2008 00:14:32 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The following page has been changed by JimKellerman:
http://wiki.apache.org/hadoop/Hbase/HowToCommit

The comment on the change is:
Initial version. Still need to add jira review queue as shared filter

New page:
= Guide for HBase Committers =

This page contains HBase specific guidelines for committers.

== New committers ==

New committers are encouraged to first read Apache's generic committer documentation:

 * [http://www.apache.org/dev/new-committers-guide.html Apache New Committer Guide]
 * [http://www.apache.org/dev/committers.html Apache Committer FAQ]


== Review ==

HBase committers should, as often as possible, attempt to review patches submitted by others.
 Ideally every submitted patch will get reviewed by a committer within a few days.  If a committer
reviews a patch they've not authored, and believe it to be of sufficient quality, then they
can commit the patch, otherwise the patch should be cancelled with a clear explanation for
why it was rejected.

The list of submitted patches is in the '''fix this''' [https://issues.apache.org/jira/secure/IssueNavigator.jspa?requestId=12311124&mode=hide
HBase Review Queue].  This is ordered by time of last modification.  Committers should scan
the list from top-to-bottom, looking for patches that they feel qualified to review and possibly
commit.

For non-trivial changes, it is __'''required'''__ to get another committer to review your
own patches before commit. Use "Submit Patch" like other contributors, and then wait for a
"+1" from another committer before committing.

== Reject ==

Patches should be rejected which do not adhere to the guidelines in [:Hbase/HowToContribute:
HowToContribute] and to the [:CodeReviewChecklist: code review checklist].  Committers should
always be polite to contributors and try to instruct and encourage them to contribute better
patches.  If a committer wishes to improve an unacceptable patch, then it should first be
rejected, and a new patch should be attached by the committer for review.

== Commit ==

When you commit a patch, please:

 1. Add an entry in CHANGES.txt, at the end of the appropriate section.  This should include
the Jira issue id, and the name of the contributor.
 1. Include the Jira issue id in the commit message, along with a short description of the
change and the name of the contributor if it is not you.  Be sure to get the issue id right,
as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see
these).
 1. Resolve the issue as fixed, thanking the contributor.  Always set the "Fix Version" at
this point, but please only set a single fix version, the earliest release in which the change
will appear.

[[Anchor(Documentation)]]
==== Committing Documentation ====

TBS

== Dialog ==

Committers should hang out in the #hbase room on irc.freenode.net for real-time discussions.
 However any substantive discussion (as with any off-list project-related discussion) should
be re-iterated in Jira or on the developer list.

Mime
View raw message