hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omal...@apache.org
Subject svn commit: r616486 - in /hadoop/core/trunk: CHANGES.txt conf/hadoop-default.xml src/java/org/apache/hadoop/mapred/TaskRunner.java
Date Tue, 29 Jan 2008 19:14:11 GMT
Author: omalley
Date: Tue Jan 29 11:14:09 2008
New Revision: 616486

URL: http://svn.apache.org/viewvc?rev=616486&view=rev
Log:
HADOOP-2723. Fixed the check for checking whether to do user task
profiling. Contributed by Amareshwari Sri Ramadasu.

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/conf/hadoop-default.xml
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/TaskRunner.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=616486&r1=616485&r2=616486&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Tue Jan 29 11:14:09 2008
@@ -601,6 +601,9 @@
     for runningMapTasks/runningReduceTasks. (Amar Kamat and Arun Murthy 
     via ddas)
 
+    HADOOP-2723. Fixed the check for checking whether to do user task
+    profiling. (Amareshwari Sri Ramadasu via omalley)
+
 Release 0.15.3 - 2008-01-18
 
   BUG FIXES

Modified: hadoop/core/trunk/conf/hadoop-default.xml
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/conf/hadoop-default.xml?rev=616486&r1=616485&r2=616486&view=diff
==============================================================================
--- hadoop/core/trunk/conf/hadoop-default.xml (original)
+++ hadoop/core/trunk/conf/hadoop-default.xml Tue Jan 29 11:14:09 2008
@@ -933,6 +933,31 @@
     </description>
   </property>
 
+  <property>
+    <name>mapred.task.profile</name>
+    <value>false</value>
+    <description>To set whether the system should collect profiler
+     information for some of the tasks in this job? The information is stored
+     in the the user log directory. The value is "true" if task profiling
+     is enabled.</description>
+  </property>
+
+  <property>
+    <name>mapred.task.profile.maps</name>
+    <value>0-2</value>
+    <description> To set the ranges of map tasks to profile.
+    mapred.task.profile has to be set to true for the value to be accounted.
+    </description>
+  </property>
+
+  <property>
+    <name>mapred.task.profile.reduces</name>
+    <value>0-2</value>
+    <description> To set the ranges of reduce tasks to profile.
+    mapred.task.profile has to be set to true for the value to be accounted.
+    </description>
+  </property>
+
 <!-- ipc properties -->
 
 <property>

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/TaskRunner.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/TaskRunner.java?rev=616486&r1=616485&r2=616486&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/TaskRunner.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/TaskRunner.java Tue Jan 29 11:14:09
2008
@@ -336,11 +336,13 @@
       vargs.add("-Dhadoop.tasklog.taskid=" + taskid);
       vargs.add("-Dhadoop.tasklog.totalLogFileSize=" + logSize);
 
-      if (conf.getProfileTaskRange(t.isMapTask()
-                                   ).isIncluded(t.getPartition())) {
-        File prof = TaskLog.getTaskLogFile(taskid, TaskLog.LogName.PROFILE);
-        vargs.add("-agentlib:hprof=cpu=samples,heap=sites,force=n,thread=y,"+
-                  "verbose=n,file="+prof.toString());
+      if (conf.getProfileEnabled()) {
+        if (conf.getProfileTaskRange(t.isMapTask()
+                                     ).isIncluded(t.getPartition())) {
+          File prof = TaskLog.getTaskLogFile(taskid, TaskLog.LogName.PROFILE);
+          vargs.add("-agentlib:hprof=cpu=samples,heap=sites,force=n,thread=y,"
+                     + "verbose=n,file=" + prof.toString());
+        }
       }
 
       // Add main class and its arguments 



Mime
View raw message