hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acmur...@apache.org
Subject svn commit: r589539 - in /lucene/hadoop/trunk: CHANGES.txt src/examples/org/apache/hadoop/examples/RandomWriter.java src/java/org/apache/hadoop/util/ToolBase.java
Date Mon, 29 Oct 2007 08:17:56 GMT
Author: acmurthy
Date: Mon Oct 29 01:17:56 2007
New Revision: 589539

URL: http://svn.apache.org/viewvc?rev=589539&view=rev
Log:
HADOOP-2102.  Fix the deprecated ToolBase to pass its Configuration object to the superceding
ToolRunner to ensure it picks up the appropriate configuration resources. Contributed by Dennis
Kubes and Enis Soztutar.

Modified:
    lucene/hadoop/trunk/CHANGES.txt
    lucene/hadoop/trunk/src/examples/org/apache/hadoop/examples/RandomWriter.java
    lucene/hadoop/trunk/src/java/org/apache/hadoop/util/ToolBase.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?rev=589539&r1=589538&r2=589539&view=diff
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Mon Oct 29 01:17:56 2007
@@ -392,6 +392,10 @@
     HADOOP-2073.  Change size of VERSION file after writing contents to it.
     (Konstantin Shvachko via dhruba)
  
+    HADOOP-2102.  Fix the deprecated ToolBase to pass its Configuration object
+    to the superceding ToolRunner to ensure it picks up the appropriate
+    configuration resources. (Dennis Kubes and Enis Soztutar via acmurthy) 
+ 
   IMPROVEMENTS
 
     HADOOP-1908. Restructure data node code so that block sending and 

Modified: lucene/hadoop/trunk/src/examples/org/apache/hadoop/examples/RandomWriter.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/examples/org/apache/hadoop/examples/RandomWriter.java?rev=589539&r1=589538&r2=589539&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/examples/org/apache/hadoop/examples/RandomWriter.java (original)
+++ lucene/hadoop/trunk/src/examples/org/apache/hadoop/examples/RandomWriter.java Mon Oct
29 01:17:56 2007
@@ -42,8 +42,8 @@
 import org.apache.hadoop.mapred.Reporter;
 import org.apache.hadoop.mapred.SequenceFileOutputFormat;
 import org.apache.hadoop.mapred.lib.IdentityReducer;
+import org.apache.hadoop.util.GenericOptionsParser;
 import org.apache.hadoop.util.Tool;
-import org.apache.hadoop.util.ToolBase;
 import org.apache.hadoop.util.ToolRunner;
 
 /**
@@ -79,7 +79,7 @@
  * </configuration></xmp>
  * 
  * Equivalently, {@link RandomWriter} also supports all the above options
- * and ones supported by {@link ToolBase} via the command-line.
+ * and ones supported by {@link GenericOptionsParser} via the command-line.
  */
 public class RandomWriter extends Configured implements Tool {
   

Modified: lucene/hadoop/trunk/src/java/org/apache/hadoop/util/ToolBase.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/util/ToolBase.java?rev=589539&r1=589538&r2=589539&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/util/ToolBase.java (original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/util/ToolBase.java Mon Oct 29 01:17:56
2007
@@ -24,7 +24,7 @@
  * @deprecated This class is depracated. Classes 
  * extending ToolBase should rather implement {@link Tool} 
  * interface, and use {@link ToolRunner} for execution 
- * functionality. Alternativelly, {@link GenericOptionsParser} 
+ * functionality. Alternatively, {@link GenericOptionsParser} 
  * can be used to parse generic arguments related to hadoop 
  * framework. 
  */
@@ -51,7 +51,7 @@
    * positive non-zero values can be used to return application-specific codes.
    */
   public final int doMain(Configuration conf, String[] args) throws Exception {
-    return ToolRunner.run(this, args);
+    return ToolRunner.run(conf, this, args);
   }
 
 }



Mime
View raw message