hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Lucene-hadoop Wiki] Update of "HowToCommit" by DougCutting
Date Thu, 06 Sep 2007 22:01:02 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Lucene-hadoop Wiki" for change notification.

The following page has been changed by DougCutting:
http://wiki.apache.org/lucene-hadoop/HowToCommit

The comment on the change is:
add notes about rejecting patches

------------------------------------------------------------------------------
  
  For non-trivial changes, it is best to get another committer to review your own patches
before commit. Use "Submit Patch" like other contributors, and then wait for a "+1" from another
committer before committing.
  
+ == Reject ==
+ 
+ Patches should be rejected which do not adhere to the guidelines in HowToContribute and
to the CodeReviewChecklist.  Committers should always be polite to contributors and try to
instruct and encourage them to contribute better patches.  If a committer wishes to improve
an unacceptable patch, then it should first be rejected, and a new patch should be attached
by the committer for review.
+ 
  == Commit ==
  
  When you commit a patch, please:

Mime
View raw message