hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Lucene-hadoop Wiki] Trivial Update of "HowToContribute" by stack
Date Wed, 20 Jun 2007 19:24:19 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Lucene-hadoop Wiki" for change notification.

The following page has been changed by stack:
http://wiki.apache.org/lucene-hadoop/HowToContribute

The comment on the change is:
Move 'submit patch' process knowledge from mailing list to here

------------------------------------------------------------------------------
  
  === Contributing your work ===
  
- Finally, patches should be attached to a bug report in [http://issues.apache.org/jira/browse/HADOOP
Jira] with a comment that asks for a code review following our [:CodeReviewChecklist: code
review checklist].  When you believe that your patch is ready to be committed, select the
"Submit Patch" link.  Submitted patches will be automatically tested against "trunk" and a
success ("+1") message or failure ("-1") message will be automatically added to your bug report
in Jira.
+ Finally, patches should be attached to a bug report in [http://issues.apache.org/jira/browse/HADOOP
Jira] with a comment that asks for a code review following our [:CodeReviewChecklist: code
review checklist].  
+ 
+ When you believe that your patch is ready to be committed, select the 'Submit Patch' link
from the 'Available Workflow Actions' section in Jira.  Submitted patches will be automatically
tested against "trunk" by [http://lucene.zones.apache.org:8080/hudson/ Hudson], the lucene
project's continuous integration engine.  Upon test completion, Hudson will add a success
("+1") message or failure ("-1") to your bug report in Jira.  If your issue contains multiple
patch versions, Hudson tests the last patch uploaded.
+ 
+ Folks should run 'ant clean test javadoc checkstyle' before selecting 'Submit Patch'.  Tests
should all pass.  Javadoc should report no warnings or errors. Checkstyle's error count should
not exceed that listed at [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/lastSuccessfulBuild/artifact/trunk/build/test/checkstyle-errors.html
Checkstyle Errors]  Hudson's tests should only double-check things, and not be used as a primary
patch tester, which would create too much noise on the mailing list and in Jira.  Submitting
patches that fail Hudson testing is frowned on, (unless the failure is not actually due to
the patch).
  
  If your patch involves performance optimizations, they should be validated by benchmarks
that demonstrate an improvement.
  
  Once a "+1" comment is received from the automated patch testing system and a "+1, code
reviewed" comment is received from a code reviewer, a committer should then evaluate it within
a few days and either: commit it; or reject it with an explanation.
  
  Please be patient.  Committers are busy people too.  If no one responds to your patch after
a few days, please make friendly reminders.  Please incorporate other's suggestions into into
your patch if you think they're reasonable.  Finally, remember that even a patch that is not
committed is useful to the community.
+ 
+ Should your patch earn a -1 on the Hudson test, set the issue status to 'Resume Progress',
upload a patch with necessary fixes and then set the status to 'Submit Patch' again.
  
  Committers: for non-trivial changes, it is best to get another committer to review your
patches before commit.  Use "Submit Patch" like other contributors, and then wait for a "+1"
from another committer before committing.  Please also try to frequently review things in
the patch queue.
  

Mime
View raw message