hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Lucene-hadoop Wiki] Trivial Update of "CodeReviewChecklist" by TomWhite
Date Mon, 16 Apr 2007 20:29:31 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Lucene-hadoop Wiki" for change notification.

The following page has been changed by TomWhite:

The comment on the change is:
Fixed typo.

   * configuration entries are retrieved/set via setter/getter methods
   * implementation details do NOT leak into interfaces
   * variables and arguments should be interfaces where possible
-  * if {{{equals}}} is overridden then {{{hashCode}}} is overridden (and vise versa)
+  * if {{{equals}}} is overridden then {{{hashCode}}} is overridden (and vice versa)
   * objects are checked ({{{instanceof}}}) for appropriate type before casting (use generics
if possible)
   * public API changes have been publically discussed

View raw message