hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomwh...@apache.org
Subject svn commit: r525577 - in /lucene/hadoop/trunk: CHANGES.txt src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
Date Wed, 04 Apr 2007 19:00:51 GMT
Author: tomwhite
Date: Wed Apr  4 12:00:50 2007
New Revision: 525577

URL: http://svn.apache.org/viewvc?view=rev&rev=525577
Log:
HADOOP-1163.  Fix ganglia metrics to aggregate metrics from different hosts properly.  Contributed
by Michael Bieniosek.

Modified:
    lucene/hadoop/trunk/CHANGES.txt
    lucene/hadoop/trunk/src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=525577&r1=525576&r2=525577
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Wed Apr  4 12:00:50 2007
@@ -97,6 +97,9 @@
 30. HADOOP-702.  Add tools to help automate HDFS upgrades.
     (Konstantin Shvachko via cutting)
 
+31. HADOOP-1163.  Fix ganglia metrics to aggregate metrics from different
+    hosts properly.  (Michael Bieniosek via tomwhite)
+
 
 Release 0.12.3 (not yet released)
 

Modified: lucene/hadoop/trunk/src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java?view=diff&rev=525577&r1=525576&r2=525577
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java (original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java Wed
Apr  4 12:00:50 2007
@@ -116,21 +116,11 @@
     public void emitRecord(String contextName, String recordName, OutputRecord outRec) 
         throws IOException
     {
-        
-        // metric name formed from record name and tag values
-        StringBuffer nameBuf = new StringBuffer(recordName);
-        for (String tagName : outRec.getTagNames()) {
-          nameBuf.append('.');
-          nameBuf.append(outRec.getTag(tagName));
-        }
-        nameBuf.append('.');
-        String namePrefix = new String(nameBuf);
-        
         // emit each metric in turn
         for (String metricName : outRec.getMetricNames()) {
           Object metric = outRec.getMetric(metricName);
           String type = (String) typeTable.get(metric.getClass());
-          emitMetric(namePrefix + metricName, type, metric.toString());
+          emitMetric(metricName, type, metric.toString());
         }
         
     }



Mime
View raw message