gump-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leo Simons <m...@leosimons.com>
Subject Re: svn commit: r165133
Date Sun, 01 May 2005 14:38:32 GMT
ajack@apache.org wrote:
...
> Modified: gump/branches/Gump3/pygump/python/gump/engine/__init__.py
> URL: http://svn.apache.org/viewcvs/gump/branches/Gump3/pygump/python/gump/engine/__init__.py?rev=165133&r1=165132&r2=165133&view=diff
> ==============================================================================
...
>  def _banner(version):
> @@ -221,10 +223,10 @@
>              self.workspace_verifier.verify(workspace)
>              
>              # * Pfew! All done. Now actually start *doing* stuff.
> -            self.walker.walk(workspace, self.pre_process_visitor)
> +            self.walker.walk(workspace, self.pre_process_visitor, 'pre_process')
>              # (visited_repositories, visited_modules, visited_projects) = \
> -            self.walker.walk(workspace, self.visitor)
> -            self.walker.walk(workspace, self.post_process_visitor)
> +            self.walker.walk(workspace, self.visitor, 'process')
> +            self.walker.walk(workspace, self.post_process_visitor, 'post_process')
>              
>              # That's it? Yeah! All other functionality is in the visitors :-D
>          except:

This broke a testcase:

======================================================================
FAIL: test_run (testEngine.EngineTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.4/site-packages/pmock.py", line 507, in 
_auto_verified_test
     self._real_test_method()
   File "/home/lsimons/svn/gump/branches/Gump3/gump/test/testEngine.py", 
line 242, in test_run
   File "/home/lsimons/svn/gump/branches/Gump3/gump/engine/__init__.py", 
line 233, in run
   File "/home/lsimons/svn/gump/branches/Gump3/gump/engine/__init__.py", 
line 226, in run
   File "/usr/lib/python2.4/site-packages/pmock.py", line 392, in __call__
     return self._mock.invoke(Invocation(self._name, args, kwargs))
   File "/usr/lib/python2.4/site-packages/pmock.py", line 454, in invoke
     raise MatchError.create_error(str(err), invocation, self)
MatchError: no match found
invoked walk('Blah', <pmock.Mock object at 0xb79a298c>, 'pre_process')
in:
expected once: walk(pmock.same('Blah'), pmock.same(<pmock.Mock object at 
0xb79a298c>)),
expected once: walk(pmock.same('Blah'), pmock.same(<pmock.Mock object at 
0xb79a29ec>)),
expected once: walk(pmock.same('Blah'), pmock.same(<pmock.Mock object at 
0xb79a2a4c>))

----------------------------------------------------------------------
Ran 55 tests in 0.517s

FAILED (failures=1)
======================================================================

I fixed it. Please try to run "./gump test" before every commit, and 
make sure it completes without errors.

Cheers!

Leo

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Mime
View raw message