gump-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Berin Loritsch <blorit...@apache.org>
Subject Re: Gump Descriptor for using BCEL
Date Wed, 07 May 2003 13:27:48 GMT
Fortress still isn't compiling.  Can someone make the necessary
changes to Xalan's build script?

If there is a solution that I can have for Fortress's build file,
I will be more than happy to do that.  Please, any further info
will help.

Leo Simons wrote:
> Sam Ruby wrote:
> 
>> Berin Loritsch wrote:
>>
>>> I am somewhat confused over the GUMP descriptor for Fortress.
>>>
>>> BCEL should not be required--the ANT script successfully filters out
>>> the BCEL files in a non-gump environment.  GUMP kind of forces my
>>> hand on adding the dependency on BCEL, but when I do, it still
>>> doesn't recognize it.  What's going on?
>>
>>
>> There appears to be a copy of bcel in xalan's latest jar.  This may 
>> cause problems down the road for fortress users.
> 
> 
> I can confirm this is the problem :D
> 
>> Meanwhile, I have committed a change to the xalan gump descriptor to 
>> see if I can get it to copy the latest bcel instead.
> 
> 
> I think a change to the xerces buildfile is in order. What happens is:
> 
>     <antcall target="xsltc.copy-deps-jar">
>       <param name="param_unless" value="xsltc.bcel_jar.not_needed" />
>       <param name="param_jar_name" value="${bcel.jar.name}" />
>     </antcall>
> 
> notice the "bcel.jar.name" instead of the "bcel.jar". Attached is a 
> patch which should allow the override to work. Can some xalan committer 
> check this and commit it? (CCing xalan-dev; please cc the gump list on 
> the way back ;)
> 
> An alternative is to have gump call the "unbundledjar" target and 
> reference the jar that generates. Since this will also likely remove 
> stuff like jlex from the classpath (unless projects reference xalan with 
> inherit="all"), I haven't made this change yet as it will likely break 
> things so needs testing. Patch attached though; still a good idea to do 
> this.
> 
> cheers,
> 
> - Leo
> 
> 
> ------------------------------------------------------------------------
> 
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/xml-xalan/java/build.xml,v
> retrieving revision 1.190
> diff -u -r1.190 build.xml
> --- build.xml	10 Apr 2003 14:35:02 -0000	1.190
> +++ build.xml	3 May 2003 15:04:50 -0000
> @@ -409,7 +409,7 @@
>    <!-- A parametrized target which is used to copy and expand a XSLTC support jar
-->
>    <target name="xsltc.copy-deps-jar" unless="${param_unless}">
>      <!-- copy the jar file to the build/classes directory -->
> -    <copy todir="${build.classes}" file="${bin.dir}/${param_jar_name}"/>
> +    <copy tofile="${build.classes}/${param_jar_name}" file="${param_jar}"/>
>      
>      <!-- unjar the jar file -->
>      <unjar src="${build.classes}/${param_jar_name}" dest="${build.classes}" />
> @@ -425,26 +425,31 @@
>      <antcall target="xsltc.copy-deps-jar">
>        <param name="param_unless" value="xsltc.bcel_jar.not_needed" />
>        <param name="param_jar_name" value="${bcel.jar.name}" />
> +      <param name="param_jar" value="${bcel.jar}" />
>      </antcall>
>  
>      <antcall target="xsltc.copy-deps-jar">
>        <param name="param_unless" value="xsltc.jlex_jar.not_needed" />
>        <param name="param_jar_name" value="${jlex.jar.name}" />
> +      <param name="param_jar" value="${jlex.jar}" />
>      </antcall>
>  
>      <antcall target="xsltc.copy-deps-jar">
>        <param name="param_unless" value="xsltc.java_cup_jar.not_needed" />
>        <param name="param_jar_name" value="${java_cup.jar.name}" />
> +      <param name="param_jar" value="${java_cup.jar}" />
>      </antcall>
>  
>      <antcall target="xsltc.copy-deps-jar">
>        <param name="param_unless" value="xsltc.runtime_jar.not_needed" />
>        <param name="param_jar_name" value="${runtime.jar.name}" />
> +      <param name="param_jar" value="${runtime.jar}" />
>      </antcall>
>  
>      <antcall target="xsltc.copy-deps-jar">
>        <param name="param_unless" value="xsltc.regexp_jar.not_needed" />
>        <param name="param_jar_name" value="${regexp.jar.name}" />
> +      <param name="param_jar" value="${regexp.jar}" />
>      </antcall>
>      
>      <!-- remove the old META-INF/MANIFEST.MF file -->
> 
> 
> ------------------------------------------------------------------------
> 
> Index: project/xml-xalan.xml
> ===================================================================
> RCS file: /home/cvs/jakarta-gump/project/xml-xalan.xml,v
> retrieving revision 1.49
> diff -u -r1.49 xml-xalan.xml
> --- project/xml-xalan.xml	3 May 2003 13:15:46 -0000	1.49
> +++ project/xml-xalan.xml	3 May 2003 15:15:40 -0000
> @@ -10,7 +10,7 @@
>    <project name="xml-xalan2">
>      <package>org.apache.xalan</package>
>  
> -    <ant basedir="java">
> +    <ant basedir="java" target="unbundledjar">
>        <property name="bcel.jar" reference="jarpath" project="jakarta-bcel"/>
>      </ant>
>  
> @@ -23,7 +23,7 @@
>      <work nested="java/build/classes"/>
>  
>      <home nested="java/build"/>
> -    <jar  name="xalan.jar" type="boot" id="transformer" />
> +    <jar name="xalan-unbundled.jar" type="boot" id="transformer" />
>  
>      <nag from="Sam Ruby &lt;rubys@us.ibm.com&gt;"
>           to="xalan-dev@xml.apache.org"/>
> @@ -48,7 +48,7 @@
>      <work nested="java/build/classes"/>
>  
>      <home nested="java/build/xalan-j_@@DATE@@"/>
> -    <jar  name="bin/xalan.jar" type="boot"/>
> +    <jar name="bin/xalan.jar" type="boot"/>
>      <javadoc nested="java/build/xalan-j_@@DATE@@/docs/apidocs" 
>        project="xml-xalan2"/>
>  
> 
> 
> 
> ------------------------------------------------------------------------
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: gump-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: gump-help@jakarta.apache.org



Mime
View raw message