gump-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sam Ruby <ru...@apache.org>
Subject Re: cvs commit: jakarta-gump/project avalon-excalibur.xml
Date Fri, 28 Mar 2003 16:24:51 GMT
Berin,

This doesn't look right.

If you don't want/need a property to be set, then the depend element 
should be moved outside of the <ant> element.

Otherwise, The first and the third block of lines changed were already 
correct.  The second one would simply need to be updated to match.

- Sam Ruby

bloritsch@apache.org wrote:
> bloritsch    2003/03/28 08:11:40
> 
>   Modified:    project  avalon-excalibur.xml
>   Log:
>   ensure commons collections is referenced properly
>   
>   Revision  Changes    Path
>   1.24      +3 -4      jakarta-gump/project/avalon-excalibur.xml
>   
>   Index: avalon-excalibur.xml
>   ===================================================================
>   RCS file: /home/cvs/jakarta-gump/project/avalon-excalibur.xml,v
>   retrieving revision 1.23
>   retrieving revision 1.24
>   diff -u -r1.23 -r1.24
>   --- avalon-excalibur.xml	28 Mar 2003 11:39:31 -0000	1.23
>   +++ avalon-excalibur.xml	28 Mar 2003 16:11:40 -0000	1.24
>   @@ -108,7 +108,7 @@
>            <ant basedir="component">
>                <depend property="excalibur-pool.jar" project="excalibur-pool"/>
>                <depend property="excalibur-logger.jar" project="excalibur-logger"/>
>   -	    <depend property="commons-collections" project="commons-collections"/>
>   +	    <depend project="commons-collections"/>
>                <depend property="excalibur-instrument.jar" project="excalibur-instrument"/>
>                <depend property="excalibur-instrument-manager.jar" project="excalibur-instrument-manager"/>
>                <depend property="excalibur-instrument-manager-interfaces.jar" project="excalibur-instrument-manager"/>
>   @@ -314,8 +314,7 @@
>                <property name="version" value="@@DATE@@"/>
>                <property name="excalibur-fortress.jar" project="excalibur-fortress"
reference="jarpath"/>
>                <property name="excalibur-lifecycle.jar" project="excalibur-lifecycle"
reference="jarpath"/>
>   -            <property name="commons-collections.jar"
>   -                      project="commons-collections" reference="jarpath"/>
>   +            <depend project="commons-collections"/>
>                <property name="util.concurrent.jar"
>                          project="concurrent" reference="jarpath"/>
>            </ant>
>   @@ -645,7 +644,7 @@
>            <package>org.apache.avalon.excalibur.pool</package>
>    
>            <ant basedir="pool">
>   -            <depend property="commons-collections.jar" project="commons-collections"/>
>   +            <depend project="commons-collections"/>
>                <depend property="excalibur-instrument.jar" project="excalibur-instrument"/>
>                <depend property="logkit.jar" project="avalon-logkit" runtime="true"/>
>                <property name="package-version" value="@@DATE@@"/>



Mime
View raw message