gump-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r1170102 - in /gump/metadata/project: tomcat-tc7.xml tomcat-trunk.xml
Date Tue, 13 Sep 2011 09:51:57 GMT
Author: kkolinko
Date: Tue Sep 13 09:51:57 2011
New Revision: 1170102

URL: http://svn.apache.org/viewvc?rev=1170102&view=rev
Log:
Remove checkstyle.jar property assignment in Tomcat 7.x, Tomcat trunk project.
This value is needed only when "execute.validate" property is true,

The current value that I am removing was not working. Gump failed to resolve it,
printing ERROR messages into the log and thus actually skipping it:
-ERROR- No such project [tomcat-7.0.x] for property.
-ERROR- Cannot resolve relative  to *unknown* [tomcat-7.0.x] for checkstyle.jar
-ERROR- Unhandled Property: checkstyle.jar on: Ant on Project:tomcat-tc7.0.x-test

Modified:
    gump/metadata/project/tomcat-tc7.xml
    gump/metadata/project/tomcat-trunk.xml

Modified: gump/metadata/project/tomcat-tc7.xml
URL: http://svn.apache.org/viewvc/gump/metadata/project/tomcat-tc7.xml?rev=1170102&r1=1170101&r2=1170102&view=diff
==============================================================================
--- gump/metadata/project/tomcat-tc7.xml (original)
+++ gump/metadata/project/tomcat-tc7.xml Tue Sep 13 09:51:57 2011
@@ -47,9 +47,6 @@
          path="." />
       <property name="tomcat-dbcp.home" project="tomcat-tc7.0.x-dbcp"
          reference="home" />
-      <!-- property name="checkstyle.jar" project="checkstyle"
-         reference="jarpath" / -->
-      <property name="checkstyle.jar" project="tomcat-tc7.0.x" path="BUILDING.txt" />
     </ant>
 
     <depend project="ant" inherit="runtime" />
@@ -126,9 +123,6 @@
       <property name="tomcat-dbcp.home" project="tomcat-tc7.0.x-dbcp"
          reference="home" />
       <property name="examples.sources.skip" value="true" />
-      <!-- property name="checkstyle.jar" project="checkstyle"
-         reference="jarpath" / -->
-      <property name="checkstyle.jar" project="tomcat-7.0.x" path="BUILDING.txt" />
     </ant>
 
    <depend project="ant" inherit="runtime" />
@@ -149,7 +143,6 @@
  <project name="tomcat-tc7.0.x-validate">
    <package>org.apache.catalina</package>
    <ant target="validate">
-      <!-- depend property="checkstyle.jar" project="checkstyle"/ -->
       <property name="checkstyle.jar" project="checkstyle"
             path="target/checkstyle-5.5-SNAPSHOT.jar" />
       <property name="execute.validate" value="true" />

Modified: gump/metadata/project/tomcat-trunk.xml
URL: http://svn.apache.org/viewvc/gump/metadata/project/tomcat-trunk.xml?rev=1170102&r1=1170101&r2=1170102&view=diff
==============================================================================
--- gump/metadata/project/tomcat-trunk.xml (original)
+++ gump/metadata/project/tomcat-trunk.xml Tue Sep 13 09:51:57 2011
@@ -47,9 +47,6 @@
          path="." />
       <property name="tomcat-dbcp.home" project="tomcat-trunk-dbcp"
          reference="home" />
-      <!-- property name="checkstyle.jar" project="checkstyle"
-         reference="jarpath" / -->
-      <property name="checkstyle.jar" project="tomcat-trunk" path="BUILDING.txt" />
     </ant>
 
     <depend project="ant" inherit="runtime" />
@@ -126,9 +123,6 @@
       <property name="tomcat-dbcp.home" project="tomcat-trunk-dbcp"
          reference="home" />
       <property name="examples.sources.skip" value="true" />
-      <!-- property name="checkstyle.jar" project="checkstyle"
-         reference="jarpath" / -->
-      <property name="checkstyle.jar" project="tomcat-trunk" path="BUILDING.txt" />
     </ant>
 
    <depend project="ant" inherit="runtime" />
@@ -149,7 +143,6 @@
  <project name="tomcat-trunk-validate">
    <package>org.apache.catalina</package>
    <ant target="validate">
-      <!-- depend property="checkstyle.jar" project="checkstyle"/ -->
       <property name="checkstyle.jar" project="checkstyle"
             path="target/checkstyle-5.5-SNAPSHOT.jar" />
       <property name="execute.validate" value="true" />



Mime
View raw message