gump-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leosim...@apache.org
Subject svn commit: r168417 - /gump/branches/Gump3/pygump/python/gump/engine/verifier.py
Date Thu, 05 May 2005 21:29:45 GMT
Author: leosimons
Date: Thu May  5 14:29:44 2005
New Revision: 168417

URL: http://svn.apache.org/viewcvs?rev=168417&view=rev
Log:
Implement cycle detection and error reporting.

Modified:
    gump/branches/Gump3/pygump/python/gump/engine/verifier.py

Modified: gump/branches/Gump3/pygump/python/gump/engine/verifier.py
URL: http://svn.apache.org/viewcvs/gump/branches/Gump3/pygump/python/gump/engine/verifier.py?rev=168417&r1=168416&r2=168417&view=diff
==============================================================================
--- gump/branches/Gump3/pygump/python/gump/engine/verifier.py (original)
+++ gump/branches/Gump3/pygump/python/gump/engine/verifier.py Thu May  5 14:29:44 2005
@@ -78,7 +78,7 @@
         errorType = sys.exc_info()[0]
         if errorType is CyclicDependencyError:
             errorValue = sys.exc_info()[1]
-            self.log.error("Cyclic dependencies occurred:")
+            self.log.error("The following cyclic dependencies were found:")
             print_cyclic_trace(errorValue, self.log.error)
             self.log.error("The projects involved will not be built!")
         else:
@@ -102,9 +102,6 @@
         """Sends VerificationError objects to the errorHandler argument if the
         provided model contains errors. If no errorHandler is provided, the
         exceptions are 'raise'd."""
-        # TODO: get rid of this return statement
-        #return
-        # TODO: Test this code!!!
         from gump.plugins import AbstractPlugin
         visitor = AbstractPlugin(None)
         (visited_repositories, visited_modules, visited_projects) = self.walker.walk(workspace,
visitor)
@@ -138,7 +135,6 @@
                 them only once
            2.b) store a cycle when its found
         3) return an array containing an array of cycles"""
-        #TODO: test this
         cycles = []
         for project in projects:
             needle = project



Mime
View raw message