gump-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leosim...@apache.org
Subject svn commit: r165514 - in /gump/branches/Gump3/pygump/python/gump: engine/algorithm.py plugins/__init__.py
Date Sun, 01 May 2005 14:43:45 GMT
Author: leosimons
Date: Sun May  1 07:43:44 2005
New Revision: 165514

URL: http://svn.apache.org/viewcvs?rev=165514&view=rev
Log:
Documentation on algorithms. No other changes.

* pygump/python/gump/plugins/__init__.py: refer to algorithms as being relevant.

* pygump/python/gump/engine/algorithm.py: remove references to 'MultiCastPlugin' from docstrings.

Modified:
    gump/branches/Gump3/pygump/python/gump/engine/algorithm.py
    gump/branches/Gump3/pygump/python/gump/plugins/__init__.py

Modified: gump/branches/Gump3/pygump/python/gump/engine/algorithm.py
URL: http://svn.apache.org/viewcvs/gump/branches/Gump3/pygump/python/gump/engine/algorithm.py?rev=165514&r1=165513&r2=165514&view=diff
==============================================================================
--- gump/branches/Gump3/pygump/python/gump/engine/algorithm.py (original)
+++ gump/branches/Gump3/pygump/python/gump/engine/algorithm.py Sun May  1 07:43:44 2005
@@ -41,7 +41,7 @@
 from gump.model.util import UPDATE_TYPE_CHECKOUT, UPDATE_TYPE_UPDATE
 
 class BaseErrorHandler:
-    """Base error handler for use with the MulticastPlugin.
+    """Base error handler for use with the various algorithms.
     
     This handler just re-raises a caught error.
     """
@@ -51,7 +51,7 @@
         raise type, value
 
 class LoggingErrorHandler:
-    """Logging error handler for use with the MulticastPlugin.
+    """Logging error handler for use with the various algorithms.
     
     This handler logs then just re-raises a caught error.
     """
@@ -64,7 +64,7 @@
         raise type, value
 
 class OptimisticLoggingErrorHandler:
-    """Logging error handler for use with the MulticastPlugin.
+    """Logging error handler for use with the various algorithms.
     
     This handler logs a caught error then stores it on the model.
     """
@@ -80,7 +80,7 @@
             visited_model_object.exceptions.append( (type, value, traceback) )
 
 class DumbAlgorithm:
-    """Core plugin that redirects visit_XXX calls to other plugins."""
+    """"Core" algorithm that simply redirects all visit_XXX calls to other plugins."""
     def __init__(self, plugin_list, error_handler=BaseErrorHandler()):
         self.list = plugin_list
         self.error_handler = error_handler
@@ -128,9 +128,9 @@
                 self.error_handler.handle(visitor, "{{{finalization stage}}}", type, value,
traceback)
 
 class MoreEfficientAlgorithm(DumbAlgorithm):
-    """MulticastPlugin that implements a more efficient build algorithm.
+    """Algorithm that implements a more efficient build algorithm.
 
-    This plugin detects "failure" for a particular step in the build, and when
+    This algorithm detects "failure" for a particular step in the build, and when
     it does, it sometimes skips a few steps.
     
     The following rules are implemented:
@@ -143,9 +143,6 @@
     array named "failure_cause" will be created pointing to the elements that
     "caused" them to fail.
     """
-    #def __init__(self, plugin_list):
-    #    MulticastPlugin.__init__(self, plugin_list, OptimisticLoggingErrorHandler())
-    
     def visit_module(self, module):
         # run the delegates
         try:

Modified: gump/branches/Gump3/pygump/python/gump/plugins/__init__.py
URL: http://svn.apache.org/viewcvs/gump/branches/Gump3/pygump/python/gump/plugins/__init__.py?rev=165514&r1=165513&r2=165514&view=diff
==============================================================================
--- gump/branches/Gump3/pygump/python/gump/plugins/__init__.py (original)
+++ gump/branches/Gump3/pygump/python/gump/plugins/__init__.py Sun May  1 07:43:44 2005
@@ -81,6 +81,12 @@
     output (both stdout and stderr) of their commands as a "$action_log"
     property on the relevant part of the model, where "$action" is the
     conceptual task they are performing (update,build,...).
+    
+    Additional rules and constraints
+    --------------------------------
+    Additional rules and constraints are satisfied or imposed by different
+    algorithm implementations. In general, plugins should try to assume as little
+    as possible about things like the build sequence.
     """
     def __init__(self, log):
         self.log = log



Mime
View raw message