From user-return-4524-archive-asf-public=cust-asf.ponee.io@guacamole.apache.org Tue Sep 25 16:31:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90111180675 for ; Tue, 25 Sep 2018 16:31:09 +0200 (CEST) Received: (qmail 49975 invoked by uid 500); 25 Sep 2018 14:31:08 -0000 Mailing-List: contact user-help@guacamole.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@guacamole.apache.org Delivered-To: mailing list user@guacamole.apache.org Received: (qmail 49949 invoked by uid 99); 25 Sep 2018 14:31:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2018 14:31:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 49CF9C05B9 for ; Tue, 25 Sep 2018 14:31:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.284 X-Spam-Level: ** X-Spam-Status: No, score=2.284 tagged_above=-999 required=6.31 tests=[SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.972, URI_HEX=1.313] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qaRtk1LHJJ7f for ; Tue, 25 Sep 2018 14:31:06 +0000 (UTC) Received: from n4.nabble.com (n4.nabble.com [199.38.86.66]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1E4D35F48B for ; Tue, 25 Sep 2018 14:31:06 +0000 (UTC) Received: from n4.nabble.com (localhost [127.0.0.1]) by n4.nabble.com (Postfix) with ESMTP id 4F6721D122E1 for ; Tue, 25 Sep 2018 09:31:05 -0500 (CDT) Date: Tue, 25 Sep 2018 09:31:05 -0500 (CDT) From: m99 To: user@guacamole.apache.org Message-ID: <1537885865322-0.post@n4.nabble.com> In-Reply-To: References: <1532368621857-0.post@n4.nabble.com> <1532441175257-0.post@n4.nabble.com> Subject: Re: Guacamole - Forcing full remote frame buffer update all the time instead of incremental MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit "What do you mean by this? Inspect/process it how? For what purpose?" "How does this relate to your need for full-frame updates?" Our requirement is to ensure all screen images sent to the end user in the Web browser have undergone a jpeg lossy compression (regardless of performance). This can be achieved by changing Guacamole to force jpeg encoding, thus to ensuring the jpeg lossy compression. Our patch to Guacamole 0.14 adds a new configuration option for the build (--enable-force-jpeg=yes; default is no). This patch adds an ifdef to the surface.c file to force jpeg encoding all the time if enabled during configure with this new option. Our original thought was first to perform a jpeg lossy compression on the actual frame buffer first (which we believed required a full frame buffer update all the time) then forwarding on to Guacamole, however this turned out to be a much larger effort than originally anticipated. We want to submit this patch to the Guacamole community for consideration to improve the security posture. We understand this change is tailored for a very specific use case, but as an optional configuration option, the impact of the change is very minimal. Is this patch something the Guacamole community would be interested in? I've found the following link outlining the steps to submit a change to the guacamole project, is this the process I should follow to submit the patch for consideration? https://github.com/apache/guacamole-server/blob/master/CONTRIBUTING -- Sent from: http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/