From user-return-4417-archive-asf-public=cust-asf.ponee.io@guacamole.apache.org Sun Aug 26 02:55:46 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C80E9180654 for ; Sun, 26 Aug 2018 02:55:45 +0200 (CEST) Received: (qmail 6905 invoked by uid 500); 26 Aug 2018 00:55:44 -0000 Mailing-List: contact user-help@guacamole.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@guacamole.apache.org Delivered-To: mailing list user@guacamole.apache.org Received: (qmail 6895 invoked by uid 99); 26 Aug 2018 00:55:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Aug 2018 00:55:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6338F1A1FB1 for ; Sun, 26 Aug 2018 00:55:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.971 X-Spam-Level: * X-Spam-Status: No, score=1.971 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=guac-dev-org.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id w-u1Co2mWePS for ; Sun, 26 Aug 2018 00:55:42 +0000 (UTC) Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7A1405F358 for ; Sun, 26 Aug 2018 00:55:41 +0000 (UTC) Received: by mail-oi0-f49.google.com with SMTP id m11-v6so21526415oic.2 for ; Sat, 25 Aug 2018 17:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=guac-dev-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=ScKalmms5ypGM5Pq38/VeHHS106TrXdXkNNMEFT6c4Y=; b=wr0WxYBNDlmXbYA3meVbnfJr+l1zHGf5MKcBH5Q6iR8BnZX4KkGNH4gLGajNrFzGUi 3Iced6S43oJnuFN8d9vgiIVJp6nkaFUofPvzbKPLxCC0fzE+nsRrOorh8jUOqHFl/oBO 4OpEr/x+P78gXQQOcXMSlLD2vUb4qoBedFfdyQB3MBuXvspyA/StgARu+FylF6+YIZrp aD6BxnQhXER+Joiq3qzRjvfAr18m1IKBBZ9oMxGdlhNFrdRtryk4YFUNGLspsUHK/d7R JDzGuJfCaBzgJ6dj0ljA34oeZPdcvPN1I3SUGgOPtKe4BRVnt8NcQacwvkaqRht0GIaE 51NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=ScKalmms5ypGM5Pq38/VeHHS106TrXdXkNNMEFT6c4Y=; b=ck7ZLpK6A1Fncp11ikPQbKu0FV4wEE4X+n9k3zzY/zp646C1M9KhF7hR6TBM6xhA/Y mQohbDJLZfeum1EqxdLBhTsWrd5lJZrJRzsF/huI8yVDVihT4tqc53hkQkLChx0kw1af 1F16N6lpvUw7Azu5BTC2FRVBhMenHH6e77Znuks27RYNQuv5YNwHo1wqc371zmL4ptmE IrY5/jb1hTG8S/1ZS68rqpOP0nkZfgV06LhhdKAB8bajSJENOggDK3cNrUwyB/1MnLha afrW/H5adHJG0XYLAi95bmofQihZvmC5PNPaUrgYgQK2cyCUVdb7watcU1oPcRrHVfXa yQ6w== X-Gm-Message-State: APzg51BeoahnzNOzQfiayoog28dGn/Mmcyq4PiZgIqmGG0R25kQD7jXv UGeMM+CWBuIfwQnvFash5/8cq9IqBX0WKzxTofg0S6t+ X-Google-Smtp-Source: ANB0Vdb/m+53XtsiiZZs3G5/zjoZNk3H1N96CbVs8FObCyDgn/ETpZhL2+FE7N8wHcvfp8MJnZ1FvGRDTKRNnVpCQig= X-Received: by 2002:a54:4783:: with SMTP id o3-v6mr7155231oic.139.1535244939890; Sat, 25 Aug 2018 17:55:39 -0700 (PDT) MIME-Version: 1.0 Sender: mike.jumper@guac-dev.org Received: by 2002:ac9:34ec:0:0:0:0:0 with HTTP; Sat, 25 Aug 2018 17:54:59 -0700 (PDT) X-Originating-IP: [73.15.226.52] In-Reply-To: References: From: Mike Jumper Date: Sat, 25 Aug 2018 17:54:59 -0700 X-Google-Sender-Auth: sMc9jK1NIrdIC9NvzYSe_p3mPJI Message-ID: Subject: Re: client.html modification To: user@guacamole.apache.org Content-Type: multipart/alternative; boundary="00000000000049242205744c115a" --00000000000049242205744c115a Content-Type: text/plain; charset="UTF-8" On Fri, Aug 24, 2018 at 2:34 AM, Nick Couchman wrote: > On Fri, Aug 24, 2018 at 5:26 AM YOSRA SAADALLAH > wrote: > >> Hi , >> >> I'm trying to modify /var/lib/tomcat7/webapps/guacamole/app/client/templates/client.html >> especially the menu but it doesn't change !!! >> even when i replace

{{client.name}}

with

nothing was >> changed >> ( i restarted tomcat7 and guacd and i restarted the pc ) >> > > Changing files within the deployed web application in Tomcat is not a > reliable way to make changes. These changes are likely to be overwritten > when the WAR file is redeployed, which can happen when Tomcat is > restarted. If you're needing to change part of the Guacamole code, you > should do one of two things: > - Write an extension that makes the desired modifications and deploy that > extension with the standard Guacamole WAR (http://guacamole.apache.org/ > doc/gug/guacamole-ext.html#ext-patch-html) > - Change it in source code, recompile the web application, and re-deploy > the modified WAR (http://guacamole.apache.org/ > doc/gug/installing-guacamole.html#building-guacamole-client) > > Also, make sure to clear your browser's cache when making these changes - > HTML files are likely to be cached by the browser and even if the changes > are successfully made and deployed, you may not see them for the lifetime > of the cache. > > The above is correct, but I'd like to additionally point out that unless you (Yosra) intend to manually port your changes to new versions of guacamole-client as upstream changes are made, it is far better to encapsulate your changes in an extension (Nick's first suggestion above). This is why that mechanism exists within the extension system. Manually modifying the source is not generally a maintainable approach to customization. - Mike --00000000000049242205744c115a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On F= ri, Aug 24, 2018 at 2:34 AM, Nick Couchman <vnick@apache.org>= wrote:
On Fri, Aug 24, 2018 at = 5:26 AM YOSRA SAADALLAH <yosra.saadallah@enis.tn> wrote:
3D""
Hi ,=C2=A0

I'm= trying to modify /var/lib/tomcat7/webapps/guacamole/app/client/t= emplates/client.html=C2=A0 =C2=A0 =C2=A0especially the menu=C2=A0 but it do= esn't change !!!
even when i replace <h2>{{client.name}}</h2> with <h2>= </h2> nothing was changed
( i restarted tomcat7 and guacd and i r= estarted the pc )=C2=A0

C= hanging files within the deployed web application in Tomcat is not a reliab= le way to make changes.=C2=A0 These changes are likely to be overwritten wh= en the WAR file is redeployed, which can happen when Tomcat is restarted.= =C2=A0 If you're needing to change part of the Guacamole code, you shou= ld do one of two things:
- Write an extension that makes the desi= red modifications and deploy that extension with the standard Guacamole WAR= (http://guacamole.apache.org/doc/gug/guacamo= le-ext.html#ext-patch-html)
- Change it in source code, = recompile the web application, and re-deploy the modified WAR (http://guacamole.apache.org/doc/gug/ins= talling-guacamole.html#building-guacamole-client)=C2=A0
=

Also, make sure to clear your browser's cache when = making these changes - HTML files are likely to be cached by the browser an= d even if the changes are successfully made and deployed, you may not see t= hem for the lifetime of the cache.

The above is correct, but I'd like to additionally point ou= t that unless you (Yosra) intend to manually port your changes to new versi= ons of guacamole-client as upstream changes are made, it is far better to e= ncapsulate your changes in an extension (Nick's first suggestion above)= . This is why that mechanism exists within the extension system. Manually m= odifying the source is not generally a maintainable approach to customizati= on.

- Mike

--00000000000049242205744c115a--