guacamole-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hankins <jhank...@homewood.k12.al.us>
Subject Re: Error message when disconnecting a Windows Server 2012
Date Mon, 13 Nov 2017 17:53:54 GMT
FWIW,

Re: my recent message to this list:
http://mail-archives.apache.org/mod_mbox/incubator-guacamole-user/201711.mbox/ajax/%3CCAAiD57hsi8mVYhwt33F9Rc2Uq_X6KoUUX%2BOSr6C8V3mX%2BGXjYQ%40mail.gmail.com%3E

"Need guidance with suspected auto-reconnect bug
<http://mail-archives.apache.org/mod_mbox/incubator-guacamole-user/201711.mbox/ajax/%3CCAAiD57hsi8mVYhwt33F9Rc2Uq_X6KoUUX%2BOSr6C8V3mX%2BGXjYQ%40mail.gmail.com%3E>
"

I noticed that this patch hits the same code I identified as causing the
0x5 not to reach the client, and the auto-reconnect to ping-pong back and
forth reconnecting after the 15s countdown. This patch fixes my issue. I am
on Server 2012 r2.

-Jonathan Hankins

On Mon, Nov 13, 2017 at 10:27 AM Frode Langelo <frode@apache.org> wrote:

> I am seeing the same behavior as Kevin; Windows 2008 does not give
> this error, while both 2012 and 2016 do. I found the easiest way to
> reproduce this is to connect to the box but not do anything in the
> Windows logon screen. The RDP server will disconnect the session and
> the referenced error is produced. The freerdp version I am using is
> 1.1.0~git20140921.
>
> Kevin; try adding this to src/protocols/rdp/rdp.c for remedy:
>
> diff --git a/src/protocols/rdp/rdp.c b/src/protocols/rdp/rdp.c
> index 0b15d055..d35c663c 100644
> --- a/src/protocols/rdp/rdp.c
> +++ b/src/protocols/rdp/rdp.c
> @@ -764,9 +764,16 @@ static int
> guac_rdp_handle_connection(guac_client* client) {
>
>                  /* Check the libfreerdp fds */
>                  if (!freerdp_check_fds(rdp_inst)) {
> -                    guac_client_abort(client,
> -                            GUAC_PROTOCOL_STATUS_UPSTREAM_UNAVAILABLE,
> -                            "Error handling RDP file descriptors");
> +                    /* Handle RDP disconnect */
> +                    if (freerdp_shall_disconnect(rdp_inst)) {
> +                        guac_rdp_client_abort(client);
> +                    }
> +                    /* Handle FD error */
> +                    else {
> +                        guac_client_abort(client,
> +                                GUAC_PROTOCOL_STATUS_UPSTREAM_UNAVAILABLE,
> +                                "Error handling RDP file descriptors");
> +                    }
>                      pthread_mutex_unlock(&(rdp_client->rdp_lock));
>                      return 1;
>                  }
>
> Kind regards,
> Frode
>
> On Mon, Oct 9, 2017 at 9:08 AM, Nick Couchman <vnick@apache.org> wrote:
> > On Mon, Oct 9, 2017 at 6:09 AM, Kevin Rivrain <Kevin.Rivrain@netplus.fr>
> > wrote:
> >>
> >> Hello,
> >>
> >>
> >>
> >> For information I quickly tested Guacamole installation on Centos 7 (my
> >> previous installations were on Debian 8) and I don’t have the problem
> when I
> >> logout from Windows now…
> >
> >
> > Interesting.
> >
> >>
> >>
> >>
> >> On Debian, the version of freerdp is 1.1.0 and on Centos 1.0.2. And, I
> do
> >> not have some libraries on Centos (libavcodec, libavutil, libswscale,
> >> libtelnet), I'll look for why. I do not know why it's OK on Centos and
> not
> >> on Debian.
> >
> >
> > I'm using FreeRDP 1.1.0 on CentOS 7 that I compiled from git, and I do
> not
> > see the issue.  I also have another CentOS system with FreeRDP 1.0.x that
> > does not exhibit the problem.  I wonder if the Debian package has some
> other
> > patch applied to it that is causing this behavior...
> >
> > -Nick
>

-- 
This e-mail is intended only for the recipient and may contain confidential 
or proprietary information. If you are not the intended recipient, the 
review, distribution, duplication or retention of this message and its 
attachments is prohibited. Please notify the sender of this error 
immediately by reply e-mail, and permanently delete this message and its 
attachments in any form in which they may have been preserved.

Mime
View raw message