Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 289C9200C0D for ; Tue, 17 Jan 2017 04:30:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 271A8160B4D; Tue, 17 Jan 2017 03:30:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 23C0F160B41 for ; Tue, 17 Jan 2017 04:30:45 +0100 (CET) Received: (qmail 98740 invoked by uid 500); 17 Jan 2017 03:30:44 -0000 Mailing-List: contact user-help@guacamole.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@guacamole.incubator.apache.org Delivered-To: mailing list user@guacamole.incubator.apache.org Received: (qmail 98730 invoked by uid 99); 17 Jan 2017 03:30:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 03:30:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 783D6C0748 for ; Tue, 17 Jan 2017 03:30:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.398 X-Spam-Level: ** X-Spam-Status: No, score=2.398 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id iUSorMkuhWJe for ; Tue, 17 Jan 2017 03:30:42 +0000 (UTC) Received: from mail-ua0-f171.google.com (mail-ua0-f171.google.com [209.85.217.171]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A177C5F5D3 for ; Tue, 17 Jan 2017 03:30:41 +0000 (UTC) Received: by mail-ua0-f171.google.com with SMTP id y9so94719573uae.2 for ; Mon, 16 Jan 2017 19:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=QurQ0XMZsQ7TtPPgARL0Y0E3dsTksyne2x5RJx2SEsQ=; b=Xdi4UMyJRu+qUsfboClYtxi2gdChSu5JO/vDXCgb/dyHxNEZedV/+/FXt1pEKxJqma txajQ/z0Bd3mBLc89j44OS9LSOK529A3AEwTq+3aLd9hVjVzPlpUEG7khQlXpXplu25f o38KkbvAmyK2vpLuIsYBYjJcEmxlxKONaAebEE+QziCwEqk3xtEtSAgn4qFEN68wCh6E a8k5vBe35gAhgphtiPXc2SoZXi5nRGNxZzsXMtOKOWVUJl/k+9w8QlEqQIQXIN27oI6q TpiXbEHwfL7yteAjoJuvoGqkXTuxZ8laiWzxoI1IoNpT2TfZm6je+wa3c4jkg08GMEkZ ui0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=QurQ0XMZsQ7TtPPgARL0Y0E3dsTksyne2x5RJx2SEsQ=; b=ulMuR/zmhEZ311O0Rk9sU7DhdO5kC6JnGFdW6VLxI6S8nvdYweWi4whgrMS0YvjgNa HDhCRxjyvy1bAgcnrvc/TMlFsWqpL0G+SHp+KnE6dfMHgMKoNwaqh58AJUGsTf2NbsAm C//G7wBr3JOFeKLpJa5YGpqvUTP+lf3QP6Tzbo8Wv5EC20n9WtnR/JuVY0xP1n3vLX27 NQlKuLwSOblWKhDr93u4Fs7+lDIwbF63FcP0YXMZmggca4unly8TOA+/fl1hD3r9uca0 gw8XebFT1XfjRfqVhsEIeaJ3pKODGf/ALcY/zj+3d6MNKDmPUyGqHv2h3E/Xp9QCqcGU IvaQ== X-Gm-Message-State: AIkVDXKB8SSKoQWBdKS1Zx7O8bpbb68FSLSddM6svzJxQkvckC25M1gD3ILy96clp6S6U/RTX5BuQs7EuJcVYQ== X-Received: by 10.176.2.86 with SMTP id 80mr19583761uas.11.1484623835369; Mon, 16 Jan 2017 19:30:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.118.131 with HTTP; Mon, 16 Jan 2017 19:30:34 -0800 (PST) In-Reply-To: References: From: Peter Burdine Date: Mon, 16 Jan 2017 19:30:34 -0800 Message-ID: Subject: Re: Is it possible to disable the Local clipboard integration To: user@guacamole.incubator.apache.org Content-Type: multipart/alternative; boundary=001a113cf1a85516bf054641ece4 archived-at: Tue, 17 Jan 2017 03:30:47 -0000 --001a113cf1a85516bf054641ece4 Content-Type: text/plain; charset=UTF-8 I loaded up a new VM that hadn't seen the site before and still got prompted. I'm not quite sure how much cleaner I can make the cache. From indexController.js: /** * Checks whether the clipboard data has changed, firing a new * "guacClipboard" event if it has. */ /** var checkClipboard = function checkClipboard() { clipboardService.getLocalClipboard().then(function clipboardRead(data) { $scope.$broadcast('guacClipboard', data); }); }; // Attempt to read the clipboard if it may have changed $window.addEventListener('load', checkClipboard, true); $window.addEventListener('copy', checkClipboard, true); $window.addEventListener('cut', checkClipboard, true); $window.addEventListener('focus', function focusGained(e) { // Only recheck clipboard if it's the window itself that gained focus if (e.target === $window) checkClipboard(); }, true); */ From clientController.js // Watch clipboard for new data, associating it with any pressed keys $scope.$watch('client.clipboardData', function clipboardChanged(data) { // Sync local clipboard as long as the menu is not open //if (!$scope.menu.shown) // clipboardService.setLocalClipboard(data); // Associate new clipboard data with any currently-pressed key for (var keysym in keysCurrentlyPressed) clipboardDataFromKey[keysym] = data; }); and $scope.$on('guacKeyup', function keyupListener(event, keysym, keyboard) { // Sync local clipboard with any clipboard data received while this // key was pressed (if any) as long as the menu is not open //var clipboardData = clipboardDataFromKey[keysym]; //if (clipboardData && !$scope.menu.shown) //clipboardService.setLocalClipboard(clipboardData); // Mark key as released delete clipboardDataFromKey[keysym]; delete keysCurrentlyPressed[keysym]; }); As best I can tell that matches the provided links. On Mon, Jan 16, 2017 at 7:06 PM, Mike Jumper wrote: > Ruthlessly clear browser cache. > > > On Mon, Jan 16, 2017 at 7:05 PM, Peter Burdine wrote: > >> I rebuild the .war after making those modification and we still get a >> prompt as soon as the users open the login page they are still getting that >> prompt. >> >> Do you have any other suggestions? >> >> Thanks, >> Peter >> >> On Sun, Jan 15, 2017 at 10:03 PM, Mike Jumper >> wrote: >> >>> You would need to edit the source of Guacamole and remove the various >>> calls to "clipboardService", which is the service that attempts to >>> read/write the local clipboard: >>> >>> https://github.com/apache/incubator-guacamole-client/blob/0. >>> 9.10-incubating/guacamole/src/main/webapp/app/index/controll >>> ers/indexController.js#L128-L148 >>> >>> https://github.com/apache/incubator-guacamole-client/blob/0. >>> 9.10-incubating/guacamole/src/main/webapp/app/client/control >>> lers/clientController.js#L409-L411 >>> >>> https://github.com/apache/incubator-guacamole-client/blob/0. >>> 9.10-incubating/guacamole/src/main/webapp/app/client/control >>> lers/clientController.js#L515-L519 >>> >>> If you do that and rebuild the .war, local clipboard will no longer be >>> integrated, and you will not be prompted. It'd be awfully nice if the >>> browser would just remember the permission grant per-domain... >>> >>> - Mike >>> >>> >>> On Sat, Jan 14, 2017 at 10:43 AM, Peter Burdine >>> wrote: >>> > Thank you for the new release! >>> > >>> > Our users are getting prompted to enable clipboard integration each >>> time >>> > they login. We are disabling RDP clipboard on the server side >>> anyway. Is >>> > it possible to disable this on the client side? >>> > >>> > Thank. >>> >> >> > --001a113cf1a85516bf054641ece4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I loaded up a new VM that hadn't seen the site before = and still got prompted.=C2=A0 I'm not quite sure how much cleaner I can= make the cache.

From indexController.js:
=C2=A0= =C2=A0 /**
=C2=A0 =C2=A0 =C2=A0* Checks whether the clipboard da= ta has changed, firing a new
=C2=A0 =C2=A0 =C2=A0* "guacClip= board" event if it has.
=C2=A0 =C2=A0 =C2=A0*/
=C2= =A0 =C2=A0 /** var checkClipboard =3D function checkClipboard() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 clipboardService.getLocalClipboard().then(func= tion clipboardRead(data) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 $scope.$broadcast('guacClipboard', data);
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 });
=C2=A0 =C2=A0 };

= =C2=A0 =C2=A0 // Attempt to read the clipboard if it may have changed
=
=C2=A0 =C2=A0 $window.addEventListener('load', =C2=A0checkClip= board, true);
=C2=A0 =C2=A0 $window.addEventListener('copy= 9;, =C2=A0checkClipboard, true);
=C2=A0 =C2=A0 $window.addEventLi= stener('cut', =C2=A0 checkClipboard, true);
=C2=A0 =C2=A0= $window.addEventListener('focus', function focusGained(e) {
<= div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 // Only recheck clipboard if= it's the window itself that gained focus
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 if (e.target =3D=3D=3D $window)
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 checkClipboard();

=C2=A0 =C2= =A0 }, true); */


From clientC= ontroller.js
=C2=A0 =C2=A0 // Watch clipboard for new data, = associating it with any pressed keys
=C2=A0 =C2=A0 $scope.$watch(= 'client.clipboardData', function clipboardChanged(data) {

=C2=A0 =C2=A0 =C2=A0 =C2=A0 // Sync local clipboard as long= as the menu is not open
=C2=A0 =C2=A0 =C2=A0 =C2=A0 //if (!$scop= e.menu.shown)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 // =C2=A0 =C2=A0clipboa= rdService.setLocalClipboard(data);

=C2=A0 =C2=A0 = =C2=A0 =C2=A0 // Associate new clipboard data with any currently-pressed ke= y
=C2=A0 =C2=A0 =C2=A0 =C2=A0 for (var keysym in keysCurrentlyPre= ssed)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 clipboardDataFrom= Key[keysym] =3D data;

=C2=A0 =C2=A0 });

and

=C2=A0 =C2=A0 $scope= .$on('guacKeyup', function keyupListener(event, keysym, keyboard) {=

=C2=A0 =C2=A0 =C2=A0 =C2=A0 // Sync local clipboa= rd with any clipboard data received while this
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 // key was pressed (if any) as long as the menu is not open
=C2=A0 =C2=A0 =C2=A0 =C2=A0 //var clipboardData =3D clipboardDataFrom= Key[keysym];
=C2=A0 =C2=A0 =C2=A0 =C2=A0 //if (clipboardData &= ;& !$scope.menu.shown)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 //clipboardService.setLocalClipboard(clipboardData);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 // Mark key as released
=C2=A0= =C2=A0 =C2=A0 =C2=A0 delete clipboardDataFromKey[keysym];
=C2=A0= =C2=A0 =C2=A0 =C2=A0 delete keysCurrentlyPressed[keysym];

=C2=A0 =C2=A0 });

As best I can tel= l that matches the provided links.
On Mon, Jan 16, 2017 at 7:06 PM, Mike Jumper <= span dir=3D"ltr"><mike.jumper@guac-dev.org> wrote:
Ruthlessly clear browser cache.

=
On Mon, Jan 16, 2017 at 7:05 PM, Peter Burdi= ne <pburdine@gmail.com> wrote:
I rebuild the .war after making those modification a= nd we still get a prompt as soon as the users open the login page they are = still getting that prompt.

Do you have any other suggest= ions?

Thanks,
Peter
=

On Sun, Jan 15, 2= 017 at 10:03 PM, Mike Jumper <mike.jumper@guac-dev.org> wrote:
You would need to edit the sour= ce of Guacamole and remove the various
calls to "clipboardService", which is the service that attempts t= o
read/write the local clipboard:

https://github.com/apac= he/incubator-guacamole-client/blob/0.9.10-incubating/guacamole/sr= c/main/webapp/app/index/controllers/indexController.js#L128-= L148

https://github.com/ap= ache/incubator-guacamole-client/blob/0.9.10-incubating/guacamole/= src/main/webapp/app/client/controllers/clientController.js#L409-<= wbr>L411

https://github.com/ap= ache/incubator-guacamole-client/blob/0.9.10-incubating/guacamole/= src/main/webapp/app/client/controllers/clientController.js#L515-<= wbr>L519

If you do that and rebuild the .war, local clipboard will no longer be
integrated, and you will not be prompted. It'd be awfully nice if the browser would just remember the permission grant per-domain...

- Mike


On Sat, Jan 14, 2017 at 10:43 AM, Peter Burdine <pburdine@gmail.com> wrote:
> Thank you for the new release!
>
> Our users are getting prompted to enable clipboard integration each ti= me
> they login.=C2=A0 We are disabling RDP clipboard on the server side an= yway.=C2=A0 Is
> it possible to disable this on the client side?
>
> Thank.



--001a113cf1a85516bf054641ece4--