Mailing-List: contact user-help@guacamole.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@guacamole.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAOSM=oe_H_4zcmnO9EGDdK7c2PbPYn2zL8dOd87J6_7FN1oUMw@mail.gmail.com>
References: <CAOSM=ofnbUU44Dh0JLVLTzxAuMcWL8wb900vYG8XYPjH1cF=ow@mail.gmail.com>
 <CAOSM=oc_hAC5Vp9hN3GNQ+tDsmj60NW7S0FWBK6kXETfsyLeEg@mail.gmail.com>
 <CALKeL-M507r6M07fvGXN1qAmexQAaa5Rg5TJUn5tJQktx1HqhQ@mail.gmail.com> <CAOSM=oe_H_4zcmnO9EGDdK7c2PbPYn2zL8dOd87J6_7FN1oUMw@mail.gmail.com>
From: Mike Jumper <mike.jumper@guac-dev.org>
Date: Mon, 12 Dec 2016 13:14:03 -0800
Message-ID: <CALKeL-Nt=9aQb+vL7mYAZFBHJNakUFHPpDkM8EFAV8a5pb1vpQ@mail.gmail.com>
Subject: Re: Error while saving a file from application to Guac virtual drive
To: user@guacamole.incubator.apache.org
Content-Type: multipart/alternative; boundary=94eb2c12464453ed3f05437c95a7
archived-at: Mon, 12 Dec 2016 21:14:14 -0000

--94eb2c12464453ed3f05437c95a7
Content-Type: text/plain; charset=UTF-8

On Mon, Dec 12, 2016 at 12:53 PM, Antony Awaida <antony@apporto.com> wrote:

> Hi again Mike:
>
> What if we create a "staging" download folder and there is a script that
> checks the size the folder every X seconds. Once the size of the folder is
> stable, it moves the file to the actual Guac download folder?
>
>
And once that approach fails, will there be a staging folder for the
staging folder? Turtles all the way down? ;)

You can try this, of course, but it is no more guaranteed to work than what
Guacamole is already doing, and it may actually make things worse:

Your proposed heuristic assumes that a file is written continuously until
the application has finished saving the file, but this will not hold in
practice. What if the application writes the file slowly? What about
*extremely* slowly? The heuristic would incorrectly conclude that the file
is safe to download, automatically move the file to the download folder,
and effectively bypass Guacamole's own heuristics, ultimately resulting in
the download of a partial file.

- Mike

--94eb2c12464453ed3f05437c95a7
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On M=
on, Dec 12, 2016 at 12:53 PM, Antony Awaida <span dir=3D"ltr">&lt;<a href=
=3D"mailto:antony@apporto.com" target=3D"_blank">antony@apporto.com</a>&gt;=
</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi again =
Mike:<div><br></div><div>What if we create a &quot;staging&quot; download f=
older and there is a script that checks the size the folder every X seconds=
. Once the size of the folder is stable, it moves the file to the actual Gu=
ac download folder?</div><div><br></div></div></blockquote><div><br></div><=
div>And once that approach fails, will there be a staging folder for the st=
aging folder? Turtles all the way down? ;)</div><div><br></div><div>You can=
 try this, of course, but it is no more guaranteed to work than what Guacam=
ole is already doing, and it may actually make things worse:</div><div><br>=
</div><div>Your proposed heuristic assumes that a file is written continuou=
sly until the application has finished saving the file, but this will not h=
old in practice. What if the application writes the file slowly? What about=
 *extremely* slowly? The heuristic would incorrectly conclude that the file=
 is safe to download, automatically move the file to the download folder, a=
nd effectively bypass Guacamole&#39;s own heuristics, ultimately resulting =
in the download of a partial file.</div><div><br></div><div>- Mike</div><di=
v><br></div></div></div></div>

--94eb2c12464453ed3f05437c95a7--