Mailing-List: contact user-help@guacamole.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@guacamole.incubator.apache.org
MIME-Version: 1.0
Sender: dagger10k@gmail.com
In-Reply-To: <CAJjmCo8+uj=dHabcgG0KpBdkFgPciaAdxwetAp2chU4Jwt1pgw@mail.gmail.com>
References: <CAJjmCo-dGgSWjdy0L2Qwd=Y5fF+hZ30DCtW7sShJup9RK-kOCg@mail.gmail.com>
 <CAMF5GWZFOqy2hkfG_ix4vh0jPHx-_vFLYA+-Yzki=UOiL-RXSg@mail.gmail.com> <CAJjmCo8+uj=dHabcgG0KpBdkFgPciaAdxwetAp2chU4Jwt1pgw@mail.gmail.com>
From: James Muehlner <james.muehlner@guac-dev.org>
Date: Sun, 14 Aug 2016 19:17:16 -0700
Message-ID: <CAMF5GWbXnUS1K=_jUof1bdryt8k0woMBvKpntW_LmVb2yb4FFQ@mail.gmail.com>
Subject: Re: LDAPConnection a size limit of 1000 ?
To: user@guacamole.incubator.apache.org
Content-Type: multipart/alternative; boundary=94eb2c0925a6f47bea053a12d5a6
archived-at: Mon, 15 Aug 2016 02:17:44 -0000

--94eb2c0925a6f47bea053a12d5a6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey Herve,

I see that you created the pull request and associated ticket. Great! Let's
move the discussion over to Github at this point.

James


On Sun, Aug 14, 2016 at 8:05 AM, Herve Guehl <herve.guehl@gmail.com> wrote:

> Hi James,
> did my homework (though this was my first time with git :p ).
> The code in itself is not dirty (I hope ;), I just meant that it would
> better to get the results from ldap as mentionned by RFC 2696. But IMHO
> nowadays we can get more than 1000 results using a search in a ldap
> directory...
>
> Herv=C3=A9
>
>
>
> On Sun, Aug 14, 2016 at 2:54 AM, James Muehlner <
> james.muehlner@guac-dev.org> wrote:
>
>> Greetings Herve,
>>
>> In order to accept code changes into the project, we'll need a pull
>> request on GitHub <https://github.com/apache/incubator-guacamole-client>=
,
>> and a corresponding JIRA issue in the Apache JIRA
>> <https://issues.apache.org/jira/browse/GUACAMOLE>. See our contribution
>> guidelines <https://guacamole.incubator.apache.org/open-source/> for
>> more information.
>>
>> As a side note, we're always happy to accept code contributions from the
>> community, but we do try to make sure that the contributions are always =
up
>> to our code quality standards. If you feel that your patch is a bit dirt=
y,
>> it may have to be cleaned up a bit before we're ready to accept it upstr=
eam.
>>
>> James
>>
>> On Fri, Aug 5, 2016 at 12:45 PM, Herve Guehl <herve.guehl@gmail.com>
>> wrote:
>>
>>> Hi,
>>> If your active directory contains more than 1000 users in the search OU=
,
>>> you'll need to :
>>>  - Configure your active directory to extend the MaxPageSize limit
>>> (default 1000) https://technet.microsoft.com/
>>> en-us/library/cc770976%28v=3Dws.11%29.aspx
>>> - Use the included patch (a bit dirty, as it would be better to fetch
>>> results according to the max page size, but works for me) :
>>>    - it enable the possibility to get more than 1000 results for a ldap
>>> request for the guacamole-client. You will have to add ldap-maxresults:
>>> 2000   (or the value you need) in your guacamole.properties file.
>>>
>>> Have fun.
>>> Herv=C3=A9
>>>
>>
>>
>

--94eb2c0925a6f47bea053a12d5a6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hey Herve,<div><br></div><div>I see that you created the p=
ull request and associated ticket. Great! Let&#39;s move the discussion ove=
r to Github at this point.</div><div><br></div><div>James<br><div><br></div=
><div><br></div></div></div><div class=3D"gmail_extra"><br><div class=3D"gm=
ail_quote">On Sun, Aug 14, 2016 at 8:05 AM, Herve Guehl <span dir=3D"ltr">&=
lt;<a href=3D"mailto:herve.guehl@gmail.com" target=3D"_blank">herve.guehl@g=
mail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=
=3D"ltr"><div><div>Hi James,<br></div>did my homework (though this was my f=
irst time with git :p ).<br>The code in itself is not dirty (I hope ;), I j=
ust meant that it would better to get the results from ldap as mentionned b=
y RFC 2696. But IMHO nowadays we can get more than 1000 results using a sea=
rch in a ldap directory...<br><br></div>Herv=C3=A9<br><div><br><br></div></=
div><div class=3D"HOEnZb"><div class=3D"h5"><div class=3D"gmail_extra"><br>=
<div class=3D"gmail_quote">On Sun, Aug 14, 2016 at 2:54 AM, James Muehlner =
<span dir=3D"ltr">&lt;<a href=3D"mailto:james.muehlner@guac-dev.org" target=
=3D"_blank">james.muehlner@guac-dev.org</a>&gt;</span> wrote:<br><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex"><div dir=3D"ltr">Greetings Herve,<div><br></div><div>I=
n order to accept code changes into the project, we&#39;ll need a pull requ=
est on <a href=3D"https://github.com/apache/incubator-guacamole-client" tar=
get=3D"_blank">GitHub</a>, and a corresponding JIRA issue in the <a href=3D=
"https://issues.apache.org/jira/browse/GUACAMOLE" target=3D"_blank">Apache =
JIRA</a>. See our <a href=3D"https://guacamole.incubator.apache.org/open-so=
urce/" target=3D"_blank">contribution guidelines</a> for more information.<=
/div><div><br></div><div>As a side note, we&#39;re always happy to accept c=
ode contributions from the community, but we do try to make sure that the c=
ontributions are always up to our code quality standards. If you feel that =
your patch is a bit dirty, it may have to be cleaned up a bit before we&#39=
;re ready to accept it upstream.</div><div><br></div><div>James</div></div>=
<div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Fri, Aug 5, 20=
16 at 12:45 PM, Herve Guehl <span dir=3D"ltr">&lt;<a href=3D"mailto:herve.g=
uehl@gmail.com" target=3D"_blank">herve.guehl@gmail.com</a>&gt;</span> wrot=
e:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><div><div><div><=
div><div>Hi,<br></div>If your active directory contains more than 1000 user=
s in the search OU, you&#39;ll need to :<br></div>=C2=A0- Configure your ac=
tive directory to extend the MaxPageSize limit (default 1000) <a href=3D"ht=
tps://technet.microsoft.com/en-us/library/cc770976%28v=3Dws.11%29.aspx" tar=
get=3D"_blank">https://technet.microsoft.com/<wbr>en-us/library/cc770976%28=
v=3Dws.<wbr>11%29.aspx</a><br></div>- Use the included patch (a bit dirty, =
as it would be better to fetch results according to the max page size, but =
works for me) :<br></div>=C2=A0=C2=A0 - it enable the possibility to get mo=
re than 1000 results for a ldap request for the guacamole-client. You will =
have to add <span style=3D"color:rgb(31,73,125)">ldap-maxresults: 2000</spa=
n>=C2=A0<b>=C2=A0</b>

(or the value you need) in your guacamole.properties file.<br><br></div>Hav=
e fun.<br></div>Herv=C3=A9<br></div>
</blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>

--94eb2c0925a6f47bea053a12d5a6--