Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7719E200B60 for ; Sun, 14 Aug 2016 17:05:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6A6E8160AA9; Sun, 14 Aug 2016 15:05:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 861F4160A8B for ; Sun, 14 Aug 2016 17:05:29 +0200 (CEST) Received: (qmail 90000 invoked by uid 500); 14 Aug 2016 15:05:23 -0000 Mailing-List: contact user-help@guacamole.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@guacamole.incubator.apache.org Delivered-To: mailing list user@guacamole.incubator.apache.org Received: (qmail 89990 invoked by uid 99); 14 Aug 2016 15:05:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Aug 2016 15:05:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4A473C789F for ; Sun, 14 Aug 2016 15:05:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MxkZkPeCfASu for ; Sun, 14 Aug 2016 15:05:21 +0000 (UTC) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CAF615FACE for ; Sun, 14 Aug 2016 15:05:20 +0000 (UTC) Received: by mail-wm0-f52.google.com with SMTP id q128so53689549wma.1 for ; Sun, 14 Aug 2016 08:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=yoSXPeyeY5ZPbfRoml++GqDh9asM460b1XYDsC2P2N0=; b=gcTPXyge3aeguqJrcXIXDf6WYL+cHCZD7mQdgsGUxEGbSv9LKZOjRilgVOQK9c0qN/ uHtBuGKZ7fYKePVIQNtEYszR0URCtFQwyvLllpF4N+9dMwBpUP3F+SBM/1F1ePyyfE6w LB1Lbs4H1dp1//782A8IlzDDorJlF8w9vuVWI3XQD/L8Ylyp0u9OJ33LKd47CHZfeI6g P5YeJqrUcwIsQ2q1xw1X1ww5QU3FdXrfkby/UjmI6+2X+4KUy4EiMOx6GUt9t4Ih9Vom 0rggBka73bvvoNOsKktcd5HEfEy7ohmxlBBuOqYS1BVnIX/g59xcM07jaxUU5F5DNi2i XmLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=yoSXPeyeY5ZPbfRoml++GqDh9asM460b1XYDsC2P2N0=; b=lB3tMJm4QJWlW2PmHCD6oOz5ioJeiBFV1HH86M5N0lceGMqH0kvz9wBfAeD1NUEyf3 vkitKpmsk1/UOhiuoeDasbgkfoQfHEqASsh64Yeb0iCbBbrapzo64HBFyDs7+BY0eUQV bQct3wTPRTEm6TrtCyKB0ZqnwLqLsh2/nF3kPn+s+8b3SqMNkZfScGFzISjjDUB8ARu4 Fs1Q7ur0c3/iZgjhQnot3Wvki5A56rTrHhlWt8PGKE288qSOUCfND9twkujc8CjDYoXh kEAME3phouTAtgK7cFRkh1S2DgTDBeVNhqelgBVPQ+RBkcScOKwb2cV30U7FNEoHzMCI zvdA== X-Gm-Message-State: AEkoouseKTXpUoy0RtIUtIjPSZwbISSWYCWR15Q8zH8lKjUx9miNotvfJ0/hVYrrXLS4tCH2SOWzgEgkIB/psg== X-Received: by 10.28.156.213 with SMTP id f204mr8560303wme.86.1471187113622; Sun, 14 Aug 2016 08:05:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.49.3 with HTTP; Sun, 14 Aug 2016 08:05:12 -0700 (PDT) In-Reply-To: References: From: Herve Guehl Date: Sun, 14 Aug 2016 17:05:12 +0200 Message-ID: Subject: Re: LDAPConnection a size limit of 1000 ? To: user@guacamole.incubator.apache.org Content-Type: multipart/alternative; boundary=001a114b44444e7d18053a0971ad archived-at: Sun, 14 Aug 2016 15:05:30 -0000 --001a114b44444e7d18053a0971ad Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi James, did my homework (though this was my first time with git :p ). The code in itself is not dirty (I hope ;), I just meant that it would better to get the results from ldap as mentionned by RFC 2696. But IMHO nowadays we can get more than 1000 results using a search in a ldap directory... Herv=C3=A9 On Sun, Aug 14, 2016 at 2:54 AM, James Muehlner wrote: > Greetings Herve, > > In order to accept code changes into the project, we'll need a pull > request on GitHub , > and a corresponding JIRA issue in the Apache JIRA > . See our contribution > guidelines for more > information. > > As a side note, we're always happy to accept code contributions from the > community, but we do try to make sure that the contributions are always u= p > to our code quality standards. If you feel that your patch is a bit dirty= , > it may have to be cleaned up a bit before we're ready to accept it upstre= am. > > James > > On Fri, Aug 5, 2016 at 12:45 PM, Herve Guehl > wrote: > >> Hi, >> If your active directory contains more than 1000 users in the search OU, >> you'll need to : >> - Configure your active directory to extend the MaxPageSize limit >> (default 1000) https://technet.microsoft.com/ >> en-us/library/cc770976%28v=3Dws.11%29.aspx >> - Use the included patch (a bit dirty, as it would be better to fetch >> results according to the max page size, but works for me) : >> - it enable the possibility to get more than 1000 results for a ldap >> request for the guacamole-client. You will have to add ldap-maxresults: >> 2000 (or the value you need) in your guacamole.properties file. >> >> Have fun. >> Herv=C3=A9 >> > > --001a114b44444e7d18053a0971ad Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi James,
did my homework (though this = was my first time with git :p ).
The code in itself is not dirty (I hope= ;), I just meant that it would better to get the results from ldap as ment= ionned by RFC 2696. But IMHO nowadays we can get more than 1000 results usi= ng a search in a ldap directory...

Herv=C3=A9


=

On Su= n, Aug 14, 2016 at 2:54 AM, James Muehlner <james.muehlner@guac-= dev.org> wrote:
Greetings Herve,

In order to accept code changes i= nto the project, we'll need a pull request on GitHub, and a= corresponding JIRA issue in the Apache JIRA. See our contrib= ution guidelines for more information.

As a si= de note, we're always happy to accept code contributions from the commu= nity, but we do try to make sure that the contributions are always up to ou= r code quality standards. If you feel that your patch is a bit dirty, it ma= y have to be cleaned up a bit before we're ready to accept it upstream.=

James

<= div class=3D"gmail_quote">On Fri, Aug 5, 2016 at 12:45 PM, Herve Guehl <herve.guehl@gmail.com> wrote:
Hi,
If your ac= tive directory contains more than 1000 users in the search OU, you'll n= eed to :
=C2=A0- Configure your active directory to extend the Max= PageSize limit (default 1000) https://technet.m= icrosoft.com/en-us/library/cc770976%28v=3Dws.11%29.aspx
- Use the included patch (a bit dirty, as it would be better to fetch r= esults according to the max page size, but works for me) :
=C2=A0= =C2=A0 - it enable the possibility to get more than 1000 results for a ldap= request for the guacamole-client. You will have to add ldap-maxresults: 2000=C2=A0=C2=A0 (or the value you need) in your guacamole.properties file.

Hav= e fun.
Herv=C3=A9


--001a114b44444e7d18053a0971ad--