guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Couchman (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GUACAMOLE-355) CAS Module Missing Error Handling
Date Thu, 10 Aug 2017 13:39:00 GMT

    [ https://issues.apache.org/jira/browse/GUACAMOLE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121611#comment-16121611
] 

Nick Couchman edited comment on GUACAMOLE-355 at 8/10/17 1:38 PM:
------------------------------------------------------------------

So, if I do GuacamoleInvalidCredentialsException, the user is redirected back to the usual
login page, but no error message (due to the redirect).  If I do GuacamoleInsufficientCredentialsException,
the user is brought to a not-quite-so-nice-looking login page (which I'm sure could be easily
brushed up), but is actually given the error message.  The Invalid exception sounds more correct;
the Insufficient exception behaves more correctly.  Thoughts on which way to go?  Or a completely
different direction?

Attached screenshots of each:
* Insufficient Login (with error): [^guac-cas-insufficient-login.png]
* Invalid login (no error): [^guac-cas-invalid-login.png]


was (Author: nick.couchman@yahoo.com):
So, if I do GuacamoleInvalidCredentialsException, the user is redirected back to the usual
login page, but no error message (due to the redirect).  If I do GuacamoleInsufficientCredentialsException,
the user is brought to a not-quite-so-nice-looking login page (which I'm sure could be easily
brushed up), but is actually given the error message.  The Invalid exception sounds more correct;
the Insufficient exception behaves more correctly.  Thoughts on which way to go?

> CAS Module Missing Error Handling
> ---------------------------------
>
>                 Key: GUACAMOLE-355
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-355
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-auth-cas
>    Affects Versions: 0.9.13-incubating
>            Reporter: Nick Couchman
>            Assignee: Nick Couchman
>         Attachments: castrace.txt, guac-cas-insufficient-login.png, guac-cas-invalid-login.png
>
>
> As reported by Kaushnik on the dev mailing list, attempting to use the guacamole-auth-cas
module with an incorrect CAS authentication endpoint results in very generic and not very
useful 500 Internal Server errors rather than meaningful messages that point the user in the
right direction for correcting the error.  Need to see if the CAS framework has any built-in
error checking facilities and try to leverage those, or at least throw some more meaningful
Guacamole errors when we run into problems.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message