Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 45954200CC1 for ; Mon, 10 Jul 2017 09:59:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 441F9166F5A; Mon, 10 Jul 2017 07:59:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A7FE166F52 for ; Mon, 10 Jul 2017 09:59:27 +0200 (CEST) Received: (qmail 12610 invoked by uid 500); 10 Jul 2017 07:59:26 -0000 Mailing-List: contact commits-help@guacamole.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@guacamole.incubator.apache.org Delivered-To: mailing list commits@guacamole.incubator.apache.org Received: (qmail 12601 invoked by uid 99); 10 Jul 2017 07:59:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2017 07:59:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 129C4191ED3 for ; Mon, 10 Jul 2017 07:59:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id i6kk9I-svkgj for ; Mon, 10 Jul 2017 07:59:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 21504627C7 for ; Mon, 10 Jul 2017 07:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52543E0295 for ; Mon, 10 Jul 2017 07:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BFD924692 for ; Mon, 10 Jul 2017 07:39:00 +0000 (UTC) Date: Mon, 10 Jul 2017 07:39:00 +0000 (UTC) From: "Gregor S (JIRA)" To: commits@guacamole.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GUACAMOLE-341) GUAC_USERNAME token not defined if using guacamole-auth-header MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 10 Jul 2017 07:59:28 -0000 [ https://issues.apache.org/jira/browse/GUACAMOLE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079976#comment-16079976 ] Gregor S commented on GUACAMOLE-341: ------------------------------------ Hi [~mike.jumper], I have seen a deprecation warning and read about the changes. While it makes perfectly sense to not disable authentification on guacamole, without securing it otherwise, still I think that this functionality needs to go somewhere to enable SSO, before abandoning the noauth module completely. I am not sure if this work has been already done. If yes, pls let me know where to look for it. I will be happy to introduce the patch also there. Best regards Gregor > GUAC_USERNAME token not defined if using guacamole-auth-header > -------------------------------------------------------------- > > Key: GUACAMOLE-341 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-341 > Project: Guacamole > Issue Type: Bug > Components: guacamole-auth-header > Affects Versions: 0.9.12-incubating > Reporter: Gregor S > > To make tokenfilter work with auth-header -and noauth module.- (needed e.g. for Kerberos authentication through an Apache/Nginx Reverse Proxy, that passes REMOTE_USER header), username must be set in the credentials object, because it is added to the Tokenfilter only if username is not null in the credentials object. > basically make $\{GUAC_USERNAME} be replaced with the credentials passed though the REMOTE_USER variable. > See also: > https://github.com/glyptodon/guacamole-client/blob/b26a664d66fd14a22eb7300d29aa20390cf408ec/guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java#L118 > https://github.com/glyptodon/guacamole-client/blob/0.9.12-incubating/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java#L170 -- This message was sent by Atlassian JIRA (v6.4.14#64029)