guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <>
Subject [jira] [Created] (GUACAMOLE-347) IE may lack window.location.origin
Date Mon, 17 Jul 2017 04:28:01 GMT
Michael Jumper created GUACAMOLE-347:

             Summary: IE may lack window.location.origin
                 Key: GUACAMOLE-347
             Project: Guacamole
          Issue Type: Bug
            Reporter: Michael Jumper

>From GUACAMOLE-327:

Internet Explorer, including 11, doesn't have support for location.origin so when trying to
build the URL for the XMLHttpRequests in tunnelService.downloadStream and tunnelService.uploadToStream,
the string "undefined" gets prepended onto the URL, rendering that functionality unusable.

The workaround/polyfill for this is pretty simple and well documented on the web and is basically:

if (!window.location.origin) {
  window.location.origin = window.location.protocol + '//' + window.location.hostname + (window.location.port
? (':' + window.location.port) : '');

In addition to the above, there are other locations within the Guacamole web application which
use {{window.location.origin}} which will need to be corrected. In particular:

* Reformatting of query parameters for AngularJS
* Generation of share links
* Generation of download/upload URLs for streams

This message was sent by Atlassian JIRA

View raw message