guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjum...@apache.org
Subject [5/7] incubator-guacamole-client git commit: GUACAMOLE-101: Avoid using both StringBuilder and String concatenation.
Date Tue, 28 Mar 2017 16:29:54 GMT
GUACAMOLE-101: Avoid using both StringBuilder and String concatenation.


Project: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/commit/f54af15f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/tree/f54af15f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/diff/f54af15f

Branch: refs/heads/master
Commit: f54af15f0b89268bdb5541407ad9053e18b33c74
Parents: db9876e
Author: Nick Couchman <vnick@apache.org>
Authored: Tue Mar 28 11:29:46 2017 -0400
Committer: Nick Couchman <vnick@apache.org>
Committed: Tue Mar 28 11:29:46 2017 -0400

----------------------------------------------------------------------
 .../java/org/apache/guacamole/auth/ldap/user/UserService.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/blob/f54af15f/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
----------------------------------------------------------------------
diff --git a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
index 94763e6..d2c0cd7 100644
--- a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
+++ b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
@@ -90,7 +90,9 @@ public class UserService {
             StringBuilder userSearchFilter = new StringBuilder();
             userSearchFilter.append("(&");
             userSearchFilter.append(confService.getUserSearchFilter());
-            userSearchFilter.append("(" + escapingService.escapeLDAPSearchFilter(usernameAttribute)
+ "=*)");
+            userSearchFilter.append("(");
+            userSearchFilter.append(escapingService.escapeLDAPSearchFilter(usernameAttribute));
+            userSearchFilter.append("=*)");
             userSearchFilter.append(")");
          
 


Mime
View raw message