guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] (GUACAMOLE-194) Double memory free bug / or thread-unsafeness in guacd, called in the guac_common_ssh_destroy_user function
Date Tue, 31 Jan 2017 18:05:51 GMT

     [ https://issues.apache.org/jira/browse/GUACAMOLE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Jumper updated GUACAMOLE-194:
-------------------------------------
    Description: 
We are heavy users of the RDP feature with SSH/SFTP for file downloads and uploads.  We are
seeing frequent guacd crashes, even the first session log off can cause a crash. 

After a few sessions (Sometimes hundreds, often thousands)  the container becomes unstable,
causes very high system load and no new connections via guacamole are possible.  We typically
also see the virtual docker Ethernet adapter enter the disabled state.

{code:none|title=https://github.com/apache/incubator-guacamole-server/blob/d831a4b9dfee685d2c00f83dabff59d0be917496/src/common-ssh/guac_ssh_user.c}
void guac_common_ssh_destroy_user(guac_common_ssh_user* user) {

    /* Free private key, if present */
    if (user->private_key != NULL)
        guac_common_ssh_key_free(user->private_key);

    /* Free all other data */
    free(user->password);
    free(user->username);
    free(user);

}
{code}

  was:
We are heavy users of the RDP feature with SSH/SFTP for file downloads and uploads.  We are
seeing frequent guacd crashes, even the first session log off can cause a crash. 

After a few sessions (Sometimes hundreds, often thousands)  the container becomes unstable,
causes very high system load and no new connections via guacamole are possible.  We typically
also see the virtual docker Ethernet adapter enter the disabled state.

https://github.com/apache/incubator-guacamole-server/blob/master/src/common-ssh/guac_ssh_user.c

void guac_common_ssh_destroy_user(guac_common_ssh_user* user) {

    /* Free private key, if present */
    if (user->private_key != NULL)
        guac_common_ssh_key_free(user->private_key);

    /* Free all other data */
    free(user->password);
    free(user->username);
    free(user);

}



> Double memory free bug / or thread-unsafeness in guacd, called in the guac_common_ssh_destroy_user
function
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: GUACAMOLE-194
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-194
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacd
>    Affects Versions: 0.9.10-incubating
>         Environment: guacd docker container on ubuntu and debian
>            Reporter: Robin
>         Attachments: guacd-stack trace.txt
>
>
> We are heavy users of the RDP feature with SSH/SFTP for file downloads and uploads. 
We are seeing frequent guacd crashes, even the first session log off can cause a crash. 
> After a few sessions (Sometimes hundreds, often thousands)  the container becomes unstable,
causes very high system load and no new connections via guacamole are possible.  We typically
also see the virtual docker Ethernet adapter enter the disabled state.
> {code:none|title=https://github.com/apache/incubator-guacamole-server/blob/d831a4b9dfee685d2c00f83dabff59d0be917496/src/common-ssh/guac_ssh_user.c}
> void guac_common_ssh_destroy_user(guac_common_ssh_user* user) {
>     /* Free private key, if present */
>     if (user->private_key != NULL)
>         guac_common_ssh_key_free(user->private_key);
>     /* Free all other data */
>     free(user->password);
>     free(user->username);
>     free(user);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message