guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GUACAMOLE-166) Allow configurable element for Guacamole.Keyboard
Date Sun, 22 Jan 2017 22:51:27 GMT

    [ https://issues.apache.org/jira/browse/GUACAMOLE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833745#comment-15833745
] 

Michael Jumper commented on GUACAMOLE-166:
------------------------------------------

{quote}
If there are some other elements on the page, they will not be able to collect keyboard events.
{quote}

This is not correct. Take, for example, the numerous input fields of the admin interface.
Full control of the keyboard is only taken within the context of the client page.

{quote}
It would be nice if the client sets Keyboard listener on the element that actually contains
the client, not to the whole document ...
{quote}

That would actually break keyboard handling. If the {{Guacamole.Keyboard}} object uses an
element within the document rather than the document itself, keyboard focus becomes cumbersome
and difficult to predict.

{quote}
... or to make Keyboard element configurable.
{quote}

This is already done:

https://github.com/apache/incubator-guacamole-client/blob/005f6153f87d6d58702adc114618ad893ce04810/guacamole/src/main/webapp/app/client/types/ClientProperties.js#L71-L76

Beyond that, there is no need for this to be configurable. Keyboard events are not interfered
with outside the context of the client.

> Allow configurable element for Guacamole.Keyboard
> -------------------------------------------------
>
>                 Key: GUACAMOLE-166
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-166
>             Project: Guacamole
>          Issue Type: Wish
>          Components: guacamole
>    Affects Versions: 0.9.10-incubating
>            Reporter: Marko Nikolić
>
> Guacamole application always sets Guacamole.Keyboard on document element, thus taking
fully the keyboards.
> If there are some other elements on the page, they will not be able to collect keyboard
events. It would be nice if the client sets Keyboard listener on the element that actually
contains the client, not to the whole document, or to make Keyboard element configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message