guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GUACAMOLE-132) Build unstable since RAT plugin added
Date Sun, 04 Dec 2016 00:25:58 GMT

     [ https://issues.apache.org/jira/browse/GUACAMOLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Jumper updated GUACAMOLE-132:
-------------------------------------
    Affects Version/s: 0.9.10-incubating

> Build unstable since RAT plugin added
> -------------------------------------
>
>                 Key: GUACAMOLE-132
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-132
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-client
>    Affects Versions: 0.9.10-incubating
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Blocker
>             Fix For: 0.9.10-incubating
>
>
> From [~gtrasuk] regarding 0.9.10-incubating:
> {quote}
> When I run ‘mvn clean install’ or ‘mvn clean package’, I get  a rat failure:
> {code:none}
> 1 Unknown Licenses
> *****************************************************
> Files with unapproved licenses:
>   /Users/trasukg/devel/guacamole/guacamole-client-0.9.10-incubating/guacamole/src/main/webapp/generated/templates-main/templates.js
> {code}
> I agree that appears to be a false positive (as it’s a generated file) - maybe we’re
missing an exclusion?
> {quote}
> (See [the original email in the VOTE thread|http://mail-archives.apache.org/mod_mbox/incubator-guacamole-dev/201611.mbox/%3C8AC3FD6B-B82E-4EBD-8364-36C29C56037E@stratuscom.com%3E])
> As is, the RAT portion of the build will fail if rerun against the extracted .tar.gz,
but not when run against git. This is because the RAT plugin ignores files which match ".gitignore"
by default, and those files are not present in the source .tar.gz.
> Since RAT pays attention to ".gitignore", my $0.02 is that these files should now be
considered part of the build, and should be included in the source archive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message