Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2E46200B59 for ; Mon, 8 Aug 2016 22:42:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A17D5160AB7; Mon, 8 Aug 2016 20:42:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F11A5160A91 for ; Mon, 8 Aug 2016 22:42:27 +0200 (CEST) Received: (qmail 76963 invoked by uid 500); 8 Aug 2016 20:42:27 -0000 Mailing-List: contact commits-help@guacamole.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@guacamole.incubator.apache.org Delivered-To: mailing list commits@guacamole.incubator.apache.org Received: (qmail 76954 invoked by uid 99); 8 Aug 2016 20:42:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2016 20:42:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A80CFC0026 for ; Mon, 8 Aug 2016 20:42:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Uu4rIOARP_RP for ; Mon, 8 Aug 2016 20:42:25 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 7292F60E50 for ; Mon, 8 Aug 2016 20:42:22 +0000 (UTC) Received: (qmail 76567 invoked by uid 99); 8 Aug 2016 20:42:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2016 20:42:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 919012C0D60 for ; Mon, 8 Aug 2016 20:42:21 +0000 (UTC) Date: Mon, 8 Aug 2016 20:42:21 +0000 (UTC) From: "Michael Jumper (JIRA)" To: commits@guacamole.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (GUACAMOLE-5) Allow creation of per-connection share links MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 Aug 2016 20:42:28 -0000 [ https://issues.apache.org/jira/browse/GUACAMOLE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-5: ----------------------------------- Comment: was deleted (was: Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71090203 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ModeledConnection.java --- @@ -157,6 +158,12 @@ public void setConfiguration(GuacamoleConfiguration config) { } @Override + public Set getSharingProfileIdentifiers() --- End diff -- No, it's just not implemented. These are the API changes only, with the actual implementation of that API coming later. I figured that if I held off on the review of the API until the underlying implementation was complete, that would distract from the review of the API design itself, and make the PR way too large. ) > Allow creation of per-connection share links > -------------------------------------------- > > Key: GUACAMOLE-5 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-5 > Project: Guacamole > Issue Type: New Feature > Reporter: Michael Jumper > Assignee: Michael Jumper > Fix For: 0.9.10-incubating > > > {panel:bgColor=#FFFFEE} > *The description of this issue was copied from [GUAC-1074|https://glyptodon.org/jira/browse/GUAC-1074], an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the Apache Incubator.* > Comments, attachments, related issues, and history from prior to acceptance *have not been copied* and can be found instead at the original issue. > {panel} > Depending on connection and user permissions, users should be able to create one-time share links that allow external or internal users to share active connections. > Considering that these links may be needed by groups of users, each link should have the option to be: > # One-time use > # Multi-use (lasts until the sharing user disconnects) > Once a user joins a connection, their presence should be exposed in the interface, and the owning user should be able to grant/revoke permission to use the keyboard/mouse, kick individual users, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)