guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (GUACAMOLE-44) Upload/download of files that are more than 1 GB fail
Date Mon, 08 Aug 2016 20:45:21 GMT

     [ https://issues.apache.org/jira/browse/GUACAMOLE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Jumper updated GUACAMOLE-44:
------------------------------------
    Comment: was deleted

(was: GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/13

    GUACAMOLE-44: Avoid unnecessary allocation of temporary string for guac_rdp_ptr_to_string().

    The current code leaks the storage for the stringified pointer allocated by `guac_rdp_ptr_to_string()`,
but it's really not necessary allocate the string at all. Better that `guac_rdp_ptr_to_string()`
be provided a sufficiently-large buffer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit c881efae0c762f693fecf9a85499cb46785971e1
Author: Michael Jumper <mjumper@apache.org>
Date:   2016-06-03T18:30:05Z

    GUACAMOLE-44: Avoid unnecessary allocation of temporary string for guac_rdp_ptr_to_string().

----
)

> Upload/download of files that are more than 1 GB fail
> -----------------------------------------------------
>
>                 Key: GUACAMOLE-44
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-44
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>             Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from [GUAC-784|https://glyptodon.org/jira/browse/GUAC-784],
an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the
Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance *have not
been copied* and can be found instead at the original issue.
> {panel}
> From Chrome, after attempting upload of a file greater than 1 GB in size:
> {code:none}
> Uncaught TypeError: Cannot read property 'length' of null client-ui.js:1525
> _upload_file.reader.onloadend
> {code}
> Uploading this file via Firefox simply crashes the browser. The same issue will occur
for file downloads, as Guacamole always creates the entire file in memory before starting
the transfer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message