guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (GUACAMOLE-34) RDP connection does not close
Date Mon, 08 Aug 2016 20:39:20 GMT

     [ https://issues.apache.org/jira/browse/GUACAMOLE-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Jumper updated GUACAMOLE-34:
------------------------------------
    Comment: was deleted

(was: GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/9

    GUACAMOLE-34: Ensure client is cleaned up whenever the client thread terminates.

    From [GUACAMOLE-34](https://issues.apache.org/jira/browse/GUACAMOLE-34):
    
    > This is caused by the lack of `guac_client_abort()` or `guac_client_stop()` call
in some cases where the client thread otherwise terminates. The connection will full close
under ONLY the following circumstances:
    > 
    > 1. All users disconnect (close their browser tabs, manually select "Disconnect" within
the guac menu, etc.)
    > 2. `guac_client_stop()` is called
    > 3. `guac_client_abort()` is called
    > 
    > If the internal client disconnects and terminates its own thread, it should also
invoke `guac_client_stop()` or `guac_client_abort()` to ensure connected users are forced
off. Otherwise, users will be confused why their connection remains active with an unresponsive
remote desktop session.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-connection-close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit a64c3e017907712ed23e902d7843a5653a26bba7
Author: Michael Jumper <mjumper@apache.org>
Date:   2016-04-19T01:15:32Z

    GUACAMOLE-34: Ensure guac_client_stop() or guac_client_abort() are called in ALL cases
where the client thread terminates.

----
)

> RDP connection does not close
> -----------------------------
>
>                 Key: GUACAMOLE-34
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-34
>             Project: Guacamole
>          Issue Type: Bug
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Critical
>
> When an RDP connection is established, and the user manually disconnects by clicking
"Logoff" or "Disconnect" in the start menu, the connection is logged as terminated by guacd
yet no "Disconnected" dialog appears within the browser window.
> This does not occur for SSH.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message