guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (GUACAMOLE-5) Allow creation of per-connection share links
Date Mon, 08 Aug 2016 20:42:20 GMT

     [ https://issues.apache.org/jira/browse/GUACAMOLE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Jumper updated GUACAMOLE-5:
-----------------------------------
    Comment: was deleted

(was: Github user jmuehlner commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-client/pull/29#discussion_r71068836
  
    --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractIdentifiable.java
---
    @@ -0,0 +1,75 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.net.auth;
    +
    +
    +/**
    + * Abstract implementation of Identifiable which provides equals() and
    + * hashCode() implementations which use the identifier to determine equality.
    + * The identifier comparison is case-sensitive.
    + *
    + * @author Michael Jumper
    + */
    +public abstract class AbstractIdentifiable implements Identifiable {
    +
    +    /**
    +     * The unique string which identifies this object.
    +     */
    +    private String identifier;
    +
    +    @Override
    +    public String getIdentifier() {
    +        return identifier;
    +    }
    +
    +    @Override
    +    public void setIdentifier(String identifier) {
    +        this.identifier = identifier;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +
    +        if (identifier == null)
    +            return 0;
    +
    +        return identifier.hashCode();
    +    }
    +
    +    @Override
    +    public boolean equals(Object other) {
    +
    +        // Not equal if null or not a User
    --- End diff --
    
    Bad comment copy/paste
)

> Allow creation of per-connection share links
> --------------------------------------------
>
>                 Key: GUACAMOLE-5
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-5
>             Project: Guacamole
>          Issue Type: New Feature
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>             Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from [GUAC-1074|https://glyptodon.org/jira/browse/GUAC-1074],
an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the
Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance *have not
been copied* and can be found instead at the original issue.
> {panel}
> Depending on connection and user permissions, users should be able to create one-time
share links that allow external or internal users to share active connections.
> Considering that these links may be needed by groups of users, each link should have
the option to be:
> # One-time use
> # Multi-use (lasts until the sharing user disconnects)
> Once a user joins a connection, their presence should be exposed in the interface, and
the owning user should be able to grant/revoke permission to use the keyboard/mouse, kick
individual users, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message