guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GUACAMOLE-5) Allow creation of per-connection share links
Date Thu, 14 Jul 2016 21:44:20 GMT

    [ https://issues.apache.org/jira/browse/GUACAMOLE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378446#comment-15378446
] 

ASF GitHub Bot commented on GUACAMOLE-5:
----------------------------------------

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/28

    GUACAMOLE-5: Fix regression introduced by recent refactor of the REST API

    The recent refactor caused issues where actual type-specific implementations were not
provided for the REST resources. All REST resources **MUST** be non-generic, thus `DirectoryResource`
and `DirectoryObjectResource` **MUST NOT** be used directly. Type parameters of generic classes
will otherwise be handled by Jersey as `Object` due to type erasure, resulting in class cast
exceptions due to received JSON being deserialized as a `Map` instead of the intended type.
    
    This change also updates the logging and error handling within `RESTExceptionWrapper`
such that this sort of thing will be easier to notice going forward. Internal errors were
not being properly logged, especially those which were not subclasses of `GuacamoleException`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client subresource-regression

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit bd8c37c7375cc037254c2dec79b124baed9049dc
Author: Michael Jumper <mjumper@apache.org>
Date:   2016-07-14T20:28:45Z

    GUACAMOLE-5: Ensure all exceptions from within REST make their way to a JSON response,
even if not a GuacamoleException.

commit cdd71411fb8f8e40109ca51f3136145ccd42136a
Author: Michael Jumper <mjumper@apache.org>
Date:   2016-07-14T21:37:33Z

    GUACAMOLE-5: All REST resources MUST be non-generic. Type parameters of generic classes
will otherwise be handled as Object by Jersey due to type erasure, resulting in class cast
exceptions due to JSON being deserialized as a Map instead of the intended type.

----


> Allow creation of per-connection share links
> --------------------------------------------
>
>                 Key: GUACAMOLE-5
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-5
>             Project: Guacamole
>          Issue Type: New Feature
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>             Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from [GUAC-1074|https://glyptodon.org/jira/browse/GUAC-1074],
an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the
Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance *have not
been copied* and can be found instead at the original issue.
> {panel}
> Depending on connection and user permissions, users should be able to create one-time
share links that allow external or internal users to share active connections.
> Considering that these links may be needed by groups of users, each link should have
the option to be:
> # One-time use
> # Multi-use (lasts until the sharing user disconnects)
> Once a user joins a connection, their presence should be exposed in the interface, and
the owning user should be able to grant/revoke permission to use the keyboard/mouse, kick
individual users, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message