Mailing-List: contact commits-help@guacamole.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@guacamole.incubator.apache.org
Date: Wed, 15 Jun 2016 04:45:09 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@guacamole.incubator.apache.org
Message-ID: <JIRA.12979236.1465964565000.955.1465965909594@Atlassian.JIRA>
In-Reply-To: <JIRA.12979236.1465964565000@Atlassian.JIRA>
References: <JIRA.12979236.1465964565000@Atlassian.JIRA> <JIRA.12979236.1465964565252@arcas>
Subject: [jira] [Commented] (GUACAMOLE-52) Do not delete history records
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Jun 2016 04:45:13 -0000


    [ https://issues.apache.org/jira/browse/GUACAMOLE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331140#comment-15331140 ] 

ASF GitHub Bot commented on GUACAMOLE-52:
-----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/21


> Do not delete history records
> -----------------------------
>
>                 Key: GUACAMOLE-52
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-52
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-auth-jdbc
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Blocker
>             Fix For: 0.9.10-incubating
>
>
> The connection history records currently stored within the Guacamole database schema are always deleted when an associated user or connection is deleted (due to "ON DELETE CASCADE"). This maintains consistency, but has a number of problems:
> # Historical records become permanently unavailable if the corresponding user account or connection are deleted.
> # Table replication for the sake of providing a centralized log across multiple instances is impossible as foreign keys will not necessarily be consistent across the databases.
> This could be resolved by removing the dependencies on ID for context. While foreign keys should still be maintained, the table could be augmented to include connection name and username. If "ON DELETE CASCADE" is replaced with "ON DELETE SET NULL", consistency is maintained without compromising history.
> *NOTE:* This blocks GUACAMOLE-5, as share links depend on history records being savable for users which do not actually exist in the database.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)