Mailing-List: contact commits-help@guacamole.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@guacamole.incubator.apache.org
Date: Fri, 3 Jun 2016 18:17:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@guacamole.incubator.apache.org
Message-ID: <JIRA.12975000.1464828417000.27468.1464977879328@Atlassian.JIRA>
In-Reply-To: <JIRA.12975000.1464828417000@Atlassian.JIRA>
References: <JIRA.12975000.1464828417000@Atlassian.JIRA> <JIRA.12975000.1464828417577@arcas>
Subject: [jira] [Commented] (GUACAMOLE-44) Upload/download of files that are
 more than 1 GB fail
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 03 Jun 2016 18:18:04 -0000


    [ https://issues.apache.org/jira/browse/GUACAMOLE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314527#comment-15314527 ] 

ASF GitHub Bot commented on GUACAMOLE-44:
-----------------------------------------

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/15

    GUACAMOLE-44: ManagedFileUpload.getInstance() must not directly invoke $apply()

    As `ManagedFileUpload.getInstance()` is sometimes invoked within `$apply()`, invoking `$apply()` again directly results in a `$digest` loop and error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client fix-infdig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 0d07c0fc8d4efa5ab14739b6d0ce1c276fa252ee
Author: Michael Jumper <mjumper@apache.org>
Date:   2016-06-03T00:11:38Z

    GUACAMOLE-44: ManagedFileUpload.getInstance() must not directly invoke $apply() - it can result in an infinite $digest loop.

----


> Upload/download of files that are more than 1 GB fail
> -----------------------------------------------------
>
>                 Key: GUACAMOLE-44
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-44
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>             Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from [GUAC-784|https://glyptodon.org/jira/browse/GUAC-784], an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance *have not been copied* and can be found instead at the original issue.
> {panel}
> From Chrome, after attempting upload of a file greater than 1 GB in size:
> {code:none}
> Uncaught TypeError: Cannot read property 'length' of null client-ui.js:1525
> _upload_file.reader.onloadend
> {code}
> Uploading this file via Firefox simply crashes the browser. The same issue will occur for file downloads, as Guacamole always creates the entire file in memory before starting the transfer.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)