guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GUACAMOLE-55) Add clipboard support for images
Date Tue, 28 Jun 2016 22:08:57 GMT


ASF GitHub Bot commented on GUACAMOLE-55:

GitHub user mike-jumper opened a pull request:

    GUACAMOLE-55: Add interface-level support for image clipboard contents

    This change implements a new directive, `guacClipboard`, which provides support for image
clipboard contents in addition to text. All clipboard contents intended for (or coming from)
this directive are communicated via the `data` property on the scope as `ClipboardData` objects.
These objects are also consumed and produced by the `clipboardService` which has been refactored
to support them. All of these objects, services, etc. have been collected together into their
own "clipboard" module.

You can merge this pull request into a Git repository by running:

    $ git pull image-clipboard

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
commit 0eed6c32aeee5661f80e56d59affc12690acde75
Author: Michael Jumper <>
Date:   2016-06-22T06:55:05Z

    GUACAMOLE-55: Move clipboard functionality to a new guacClipboard directive.

commit 0edc730308c5fc78a811c56a45cd6e30997c0dc7
Author: Michael Jumper <>
Date:   2016-06-22T07:26:46Z

    GUACAMOLE-55: Only the guacClipboard directive should fire guacClipboard events.

commit 0c6383a0827a73a2f89c05e25ee00f4a1da48bbe
Author: Michael Jumper <>
Date:   2016-06-22T07:42:31Z

    GUACAMOLE-55: Clipboard element must be "position: fixed" to avoid unnecessary scrolling
of the document.

commit 01eddd2772d0285025bf448dc279a3bacc5651ff
Author: Michael Jumper <>
Date:   2016-06-22T08:09:24Z

    GUACAMOLE-55: Restore focus state after attempting to read local clipboard.

commit 65897fdb64d713e582b967ab57be23956bfeaefb
Author: Michael Jumper <>
Date:   2016-06-22T08:31:11Z

    GUACAMOLE-55: Check clipboard when guacClipboard directive is initialized.

commit 0a0933a23e935e80622b37ac292f06cdf3720a76
Author: Michael Jumper <>
Date:   2016-06-22T08:46:32Z

    GUACAMOLE-55: Clean up event handlers after guacClipboard directive is destroyed.

commit 7f08766392027977d8e14452c5be04dcbf645b1e
Author: Michael Jumper <>
Date:   2016-06-22T22:17:28Z

    GUACAMOLE-55: Add image support to the guacClipboard directive.

commit 8c5446127b1f11c63695fd125c20c32e2a1bc469
Author: Michael Jumper <>
Date:   2016-06-23T07:24:01Z

    GUACAMOLE-55: Move clipboard handling to own module. Represent clipboard contents with
ClipboardData type.

commit 17e97e43116238000391b60fcb87cbfd3d4cc98a
Author: Michael Jumper <>
Date:   2016-06-23T07:39:27Z

    GUACAMOLE-55: Improve styling of copied images.

commit 2a20aefa9284ca42a4862dc1700227703cbcf04b
Author: Michael Jumper <>
Date:   2016-06-28T01:33:15Z

    GUACAMOLE-55: Do not attempt to send empty text blobs.

commit 6e4e6454f77024bc77cc7021b0dee4d27c3cd0dc
Author: Michael Jumper <>
Date:   2016-06-28T02:32:18Z

    GUACAMOLE-55: Switch to a content-editable div for the clipboard (rather than a textarea).

commit ea5ee1825b2190d2c62b3873d20e275377b059ab
Author: Michael Jumper <>
Date:   2016-06-28T20:43:31Z

    GUACAMOLE-55: Update clipboardService to support non-text contents.

commit 16637b07321b2526dcca6869c193d6c9cf537043
Author: Michael Jumper <>
Date:   2016-06-28T21:00:53Z

    GUACAMOLE-55: Prevent clipboard events generated by the clipboardService from disturbing
the operations of the guacClipboard directive.

commit f289be05b2732eae4c057c4227b53cd87a248541
Author: Michael Jumper <>
Date:   2016-06-28T21:50:16Z

    GUACAMOLE-55: Attempt to set local clipboard with received data.

commit 942fd5dd677f21af409ea40c086cad0a422b396e
Author: Michael Jumper <>
Date:   2016-06-28T22:05:49Z

    GUACAMOLE-55: Remove unnecessary style - there is no longer a textarea in the guac menu.


> Add clipboard support for images
> --------------------------------
>                 Key: GUACAMOLE-55
>                 URL:
>             Project: Guacamole
>          Issue Type: New Feature
>          Components: guacamole, RDP
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
> The Guacamole clipboard currently only supports text, even though the protocol has been
written to support arbitrary data. The Guacamole interface and backend should be modified
such that users can copy/paste image data.
> Naturally, this will only be possible for RDP initially. VNC does not provide image support
for clipboard data, and it is unclear what behavior would be reasonable for SSH or telnet
(other than refusing the data entirely).

This message was sent by Atlassian JIRA

View raw message