guacamole-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GUACAMOLE-52) Do not delete history records
Date Wed, 15 Jun 2016 04:45:09 GMT


ASF GitHub Bot commented on GUACAMOLE-52:

Github user asfgit closed the pull request at:

> Do not delete history records
> -----------------------------
>                 Key: GUACAMOLE-52
>                 URL:
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-auth-jdbc
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Blocker
>             Fix For: 0.9.10-incubating
> The connection history records currently stored within the Guacamole database schema
are always deleted when an associated user or connection is deleted (due to "ON DELETE CASCADE").
This maintains consistency, but has a number of problems:
> # Historical records become permanently unavailable if the corresponding user account
or connection are deleted.
> # Table replication for the sake of providing a centralized log across multiple instances
is impossible as foreign keys will not necessarily be consistent across the databases.
> This could be resolved by removing the dependencies on ID for context. While foreign
keys should still be maintained, the table could be augmented to include connection name and
username. If "ON DELETE CASCADE" is replaced with "ON DELETE SET NULL", consistency is maintained
without compromising history.
> *NOTE:* This blocks GUACAMOLE-5, as share links depend on history records being savable
for users which do not actually exist in the database.

This message was sent by Atlassian JIRA

View raw message