Mailing-List: contact users-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@groovy.apache.org
MIME-Version: 1.0
In-Reply-To: <49355de5-a04b-3f97-9be3-acb064621cf3@gmail.com>
References: <trinity-6a76d260-4351-455c-8f94-536db7f90fe0-1479648323521@3capp-gmx-bs60>
 <49355de5-a04b-3f97-9be3-acb064621cf3@gmail.com>
From: Guillaume Laforge <glaforge@gmail.com>
Date: Sun, 20 Nov 2016 16:02:36 +0100
Message-ID: <CAJ2HCd-UnSEJSvbM73X6-n6Jbm2KO2qtZfa=XLm=96TFUJDh_g@mail.gmail.com>
Subject: Re: HTTPBuilder & URIBuilder - plus sign will not encoded
To: users@groovy.apache.org
Content-Type: multipart/alternative; boundary=001a1145aa786aa4b00541bcd407
archived-at: Sun, 20 Nov 2016 15:02:50 -0000

--001a1145aa786aa4b00541bcd407
Content-Type: text/plain; charset=UTF-8

I didn't know about NG, David!

These days, I tend to use groovy wslite:
https://github.com/jwagenleitner/groovy-wslite

What are the pros & cons of http-builder-ng and wslite?

On Sun, Nov 20, 2016 at 3:39 PM, David Clark <plotinussmith@gmail.com>
wrote:

> Plus sign is legal in URI's so they don't need to get encoded to be legal:
>
> http://stackoverflow.com/questions/1547899/which-
> characters-make-a-url-invalid/1547940#1547940
> This is complicated by the fact that they are url encoded when part of the
> query string, but that's not what you are doing here. It sounds to me like
> the problem is on the server or there some other part of your request that
> is incorrect.
>
> If there is a problem inside HTTPBuilder, you are probably out of luck,
> that project has been dead for a while.
>
> However, I have created a successor to HTTPBuilder called http-builder-ng
> that is active here:
>
> https://github.com/dwclark/http-builder-ng
>
> It is NOT a backwards compatible upgrade. When I was examining the
> original source code I found many threading issues, code duplication, it
> was imposible to use @TypeChecked/@CompileStatic, and found it hard to
> integrated different clients inside HTTPBuilder. The result of these
> frustrations was a ground up re-write. Bug reports/pull requests are
> encouraged.
>
>
>
> On 11/20/2016 07:25 AM, Christian Lotz wrote:
>
> Hi all,
> I try to upload files via HTTPBuilder (Groovy Version: 2.4.7 JVM: 1.8.0_40
> Vendor: Oracle Corporation OS: Mac OS X). After a couple of test I
> realized, that filenames containing a plus sign ("+") can't be uploaded.
> The REST Service responds with HTTP/1.1 400 Bad Request. After some more
> debugging I think these filenames will not get encoded correctly:
>
> uri.path = "/rest/" + objectNamespace + "/" + objectFile.name
>
> groovyx.net.http.HTTPBuilder doRequest
> FINE: PUT http://172.16.29.10/rest/TEST/s*pace%20space.doc* - Filename:
> space\ space.doc - OK
>
> groovyx.net.http.HTTPBuilder doRequest
> FINE: PUT http://172.16.29.10/rest/TEST/*plus+plus.doc* -Filename
> plus+plus.doc - ERROR
>
> All other "special" characters like spaces, #, &, % or ? will get encoded
> correctly ...
>
> Does anybody know how to resolve this issue?
>
> Thanks in advance
> Paolo
>
>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

--001a1145aa786aa4b00541bcd407
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I didn&#39;t know about NG, David!<div><br></div><div>Thes=
e days, I tend to use groovy wslite:</div><div><a href=3D"https://github.co=
m/jwagenleitner/groovy-wslite">https://github.com/jwagenleitner/groovy-wsli=
te</a><br></div><div><br></div><div>What are the pros &amp; cons of http-bu=
ilder-ng and wslite?</div></div><div class=3D"gmail_extra"><br><div class=
=3D"gmail_quote">On Sun, Nov 20, 2016 at 3:39 PM, David Clark <span dir=3D"=
ltr">&lt;<a href=3D"mailto:plotinussmith@gmail.com" target=3D"_blank">ploti=
nussmith@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 =20
   =20
 =20
  <div bgcolor=3D"#FFFFFF" text=3D"#000000">
    <p>Plus sign is legal in URI&#39;s so they don&#39;t need to get encode=
d to
      be legal:</p>
    <p><a class=3D"m_-1326121422746446169moz-txt-link-freetext" href=3D"htt=
p://stackoverflow.com/questions/1547899/which-characters-make-a-url-invalid=
/1547940#1547940" target=3D"_blank">http://stackoverflow.com/<wbr>questions=
/1547899/which-<wbr>characters-make-a-url-invalid/<wbr>1547940#1547940</a><=
br>
    </p>
    This is complicated by the fact that they are url encoded when part
    of the query string, but that&#39;s not what you are doing here. It
    sounds to me like the problem is on the server or there some other
    part of your request that is incorrect.<br>
    <br>
    If there is a problem inside HTTPBuilder, you are probably out of
    luck, that project has been dead for a while.<br>
    <br>
    However, I have created a successor to HTTPBuilder called
    http-builder-ng that is active here:<br>
    <br>
    <a class=3D"m_-1326121422746446169moz-txt-link-freetext" href=3D"https:=
//github.com/dwclark/http-builder-ng" target=3D"_blank">https://github.com/=
dwclark/<wbr>http-builder-ng</a><br>
    <br>
    It is NOT a backwards compatible upgrade. When I was examining the
    original source code I found many threading issues, code
    duplication, it was imposible to use @TypeChecked/@CompileStatic,
    and found it hard to integrated different clients inside
    HTTPBuilder. The result of these frustrations was a ground up
    re-write. Bug reports/pull requests are encouraged.<div><div class=3D"h=
5"><br>
    <br>
    <br>
    <div class=3D"m_-1326121422746446169moz-cite-prefix">On 11/20/2016 07:2=
5 AM, Christian Lotz
      wrote:<br>
    </div>
    <blockquote type=3D"cite">
      <div style=3D"font-family:Verdana;font-size:12.0px">
        <div><span style=3D"font-family:lucida sans unicode,lucida grande,s=
ans-serif">Hi all,</span></div>
        <div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">I try to=C2=A0upload=C2=A0files via HTTPBuilder
              (Groovy Version: 2.4.7 JVM: 1.8.0_40 Vendor: Oracle
              Corporation OS: Mac OS X). After a couple of test I
              realized, that filenames=C2=A0containing a plus sign (&quot;+=
&quot;)
              can&#39;t be uploaded. The REST Service responds with=C2=A0HT=
TP/1.1
              400 Bad Request. After some more debugging I think=C2=A0these
              filenames will not get encoded correctly:</span></div>
          <div>=C2=A0</div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">uri.path =3D &quot;/rest/&quot; + objectNamespace
              + &quot;/&quot; + objectFile.name</span></div>
          <div>
            <p><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">groovyx.net.http.HTTPBuilder
                doRequest<br>
                FINE: PUT <a class=3D"m_-1326121422746446169moz-txt-link-fr=
eetext" href=3D"http://172.16.29.10/rest/TEST/s" target=3D"_blank">http://1=
72.16.29.10/rest/TEST/<wbr>s</a><strong>pace%20space.doc</strong>
                - Filename: space\ space.doc - OK</span></p>
          </div>
          <div>
            <p><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">groovyx.net.http.HTTPBuilder
                doRequest<br>
                FINE: PUT <a class=3D"m_-1326121422746446169moz-txt-link-fr=
eetext" href=3D"http://172.16.29.10/rest/TEST/" target=3D"_blank">http://17=
2.16.29.10/rest/TEST/</a><strong><wbr>plus+plus.doc</strong>
                -Filename plus+plus.doc - ERROR</span></p>
          </div>
          <div>=C2=A0</div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">All other &quot;special&quot; characters like
              spaces, #, &amp;, % or ? will get=C2=A0encoded correctly ... =
</span></div>
          <div>=C2=A0</div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">Does anybody know how to resolve this
              issue?</span></div>
          <div>=C2=A0</div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">Thanks in advance</span></div>
          <div><span style=3D"font-family:lucida sans unicode,lucida grande=
,sans-serif">Paolo</span></div>
        </div>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><d=
iv><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D=
"ltr"><div dir=3D"ltr">Guillaume Laforge<br>Apache Groovy committer &amp; P=
MC Vice-President</div><div dir=3D"ltr">Developer Advocate @ Google Cloud P=
latform<br><div><br></div><div>Blog:=C2=A0<a href=3D"http://glaforge.appspo=
t.com/" target=3D"_blank">http://glaforge.appspot.com/</a><div><div>Social:=
 <a href=3D"http://twitter.com/glaforge" target=3D"_blank">@glaforge</a>=C2=
=A0/ <a href=3D"https://plus.google.com/u/0/114130972232398734985/posts" ta=
rget=3D"_blank">Google+</a></div></div></div></div></div></div></div></div>=
</div></div></div></div></div>
</div>

--001a1145aa786aa4b00541bcd407--