Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BCCF7200B36 for ; Wed, 6 Jul 2016 14:35:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BB854160A64; Wed, 6 Jul 2016 12:35:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E7FAE160A36 for ; Wed, 6 Jul 2016 14:35:30 +0200 (CEST) Received: (qmail 17812 invoked by uid 500); 6 Jul 2016 12:35:29 -0000 Mailing-List: contact users-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@groovy.apache.org Delivered-To: mailing list users@groovy.apache.org Received: (qmail 17802 invoked by uid 99); 6 Jul 2016 12:35:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2016 12:35:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7DE7CC0A84 for ; Wed, 6 Jul 2016 12:35:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.78 X-Spam-Level: * X-Spam-Status: No, score=1.78 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_EU=0.5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gr8conf-org.20150623.gappssmtp.com Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3cYfp_P7GUaU for ; Wed, 6 Jul 2016 12:35:23 +0000 (UTC) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 1C03F5F4E5 for ; Wed, 6 Jul 2016 12:35:23 +0000 (UTC) Received: by mail-wm0-f54.google.com with SMTP id r201so190832828wme.1 for ; Wed, 06 Jul 2016 05:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gr8conf-org.20150623.gappssmtp.com; s=20150623; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=eZvo7kh/WBBuAGb46d4R7BI/GpL1zbmpSfX9k+VFJY4=; b=WaTtAH/InFYsAve5K460YiTq6Zjk6Idx6tB5/CJfscWvjVVqdQY5PWP3rAvrH9zmC7 hokdgNxJa3UFw/6JKiNdXjmJK5lPt+PCkBzTRASfSWIy1Q4TwvAOyFhbNhAQ3NZqwsSa BvJi7iUlef9iZBqfWf5tRSXLUoXyizLN3ShU/gY10P5fCxPXXPbvAyYqSMgHYH+bi7bm eC9yumf4uYJqd41EmtV+0FRP1ybtSizBjGhlE70x9cOWuDbNkwI6pnVkWzOf28vMS2yO JNtZEVAS+0838mFcKuj2RIa64p75y0+EtpuMDEtqLXUfe80dfVeGMTuHsLaXmxz7YndM xmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=eZvo7kh/WBBuAGb46d4R7BI/GpL1zbmpSfX9k+VFJY4=; b=F5HmWvHutEWHV011GfvRe4DYFJ98WZ1zuFNIIMqaTEK13Lcpmu3JZXdT68I6z2vJjG 9NjiS/X58AXQK4iCo0ySpnX3dzoCHcMrEF0TNacdwpYdYqn1BKUahzz7HZ8yPE+6uOHR q/RfhBxXY6D52xFbL0kThJOY62g12E0Mm7/1T4scl2HChH3UoaFxqZpwqkIaoo/TivWy AziJRYxEqzV8RFzxSniqHIo0j6LqfoQdQbgL1EVV1WyVCKEXRA41mgy7DN5ltSXcZZYJ fJhdGWxNWz23mYZNI6Zh4V740IOv+cIblWYbus4nkI1pjaN/pNiRVLSW4n8d4CNCdm8F +GAw== X-Gm-Message-State: ALyK8tI8OMk4GvQCtWfQWt2wmPH2+9KwJYzqIRsn/EFj7gjvmXNFhAenIs3ypeEAVXm9t85JPjnTbbnw/qiahw== X-Received: by 10.194.7.70 with SMTP id h6mr20330046wja.38.1467808522707; Wed, 06 Jul 2016 05:35:22 -0700 (PDT) Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Jul 2016 08:35:22 -0400 From: =?UTF-8?Q?S=C3=B8ren_Berg_Glasius_=28GR8Conf_EU=29?= In-Reply-To: References: <577CF794.70006@gmx.org> X-Mailer: Airmail (367) MIME-Version: 1.0 Date: Wed, 6 Jul 2016 08:35:22 -0400 Message-ID: Subject: Re: changing "with" to return self or doto To: =?UTF-8?Q?C=C3=A9dric_Champeau?= , users@groovy.apache.org Content-Type: multipart/alternative; boundary=e89a8f642c989840090536f6cd1d archived-at: Wed, 06 Jul 2016 12:35:31 -0000 --e89a8f642c989840090536f6cd1d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I agree with Cedric. If you want to do a breaking change like this it should wait until a major release, not a minor. I would not expect breaking changes going from 2.4.x to 2.5.x Best regards, S=C3=B8ren Berg Glasius GR8Conf Europe organizing team GR8Conf ApS Mobile: +45 40 44 91 88, Web: www.gr8conf.eu, Skype: sbglasius Company Address: Buchwaldsgade 50, 5000 Odense C, Denmark Personal Address: Hedevej 1, Gl. Rye, 8680 Ry, Denmark --- GR8Conf - Dedicated to the Groovy Ecosystem From: C=C3=A9dric Champeau Reply: users@groovy.apache.org Date: 6. juli 2016 at 14.30.56 To: users@groovy.apache.org Subject: Re: changing "with" to return self or doto I think it's a too risky breaking change. I would go for a separate method. x.self { ... } 2016-07-06 14:20 GMT+02:00 Jochen Theodorou : > We have an overlap of https://github.com/apache/groovy/pull/174 and > https://issues.apache.org/jira/browse/GROOVY-3976. That I would like to > discuss. > > Basically 3976 is about making "with" return the object it operates on. > Right now we have > > assert 1 =3D=3D x.with {1} > assert x =3D=3D x.with {it} > > and after 3976 we would have: > > assert x =3D=3D x.with {1} > assert x =3D=3D x.with {it} > > The mentioned pull request goes with the same logic, but using a new > method. My opinion on this is, that we should go for a breaking change in > 2.5 and change "with", instead of adding another method on Object. > > What do you guys think? Do you agree, or should we keep the current > behavior, should there be a doto method instead? > > PS: just in case some people are wondering... I am trying to get some of > our old pull requests in, there are too many and keeping them open so lon= g > is an insult to contributors.. > > So if I do not forget about this and if there are no reactions I am going > to change "with" > > bye Jochen > --e89a8f642c989840090536f6cd1d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =
I agree with Cedric. If you want to do a breaking= change like this it should wait until a major release, not a minor. I woul= d not expect breaking changes going from 2.4.x to 2.5.x

Best rega= rds,
S=C3=B8ren Ber= g Glasius
GR8Conf E= urope organizing team
Mobile: +45 40 44 91 88, We= b:=C2=A0www.gr8conf.eu= , Skype: sbglasius=C2=A0
Company Addr= ess: Buchwaldsgade 50, 5000 Odense C, Denmark
Personal Address: Hedevej 1, Gl. Rye, 8680 Ry, Denmark
--- GR8Conf -=C2=A0D= edicated to the Groovy Ecosystem

From:=C2=A0C=C3=A9dric Champeau <cedric.champeau@gmail.com>
Reply:=C2=A0users@groovy.apache.org <users@groovy.apach= e.org>
Date:=C2=A06. juli 2016 at 14.= 30.56
To:=C2=A0users@groovy.apache.org <users@groovy.apache.org>
Subject:=C2= =A0 Re: changing "with" to return sel= f or doto

I think it's a too risky breaking change. I would go for a separate method. x.self { ... }

2016-07-06 14:20 GMT+02:00 Jochen Theodorou <blackdrag@gmx.org>:
We have an overlap of https://github.com/apache/groovy/pull/17= 4 and https://issues.apache.org/jira/browse/GROOVY-3976. That I would like to discuss.

Basically 3976 is about making "with" return the object it operat= es on. Right now we have

assert 1 =3D=3D x.with {1}
assert x =3D=3D x.with {it}

and after 3976 we would have:

assert x =3D=3D x.with {1}
assert x =3D=3D x.with {it}

The mentioned pull request goes with the same logic, but using a new method. My opinion on this is, that we should go for a breaking change in 2.5 and change "with", instead of adding another method on Object.

What do you guys think? Do you agree, or should we keep the current behavior, should there be a doto method instead?

PS: just in case some people are wondering... I am trying to get some of our old pull requests in, there are too many and keeping them open so long is an insult to contributors..

So if I do not forget about this and if there are no reactions I am going to change "with"

bye Jochen

--e89a8f642c989840090536f6cd1d--