From notifications-return-16133-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri Apr 12 21:11:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A8CA1180784 for ; Fri, 12 Apr 2019 23:11:01 +0200 (CEST) Received: (qmail 10276 invoked by uid 500); 12 Apr 2019 21:11:01 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 10215 invoked by uid 99); 12 Apr 2019 21:11:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2019 21:11:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74E8EE29DB for ; Fri, 12 Apr 2019 21:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 17FB12459A for ; Fri, 12 Apr 2019 21:11:00 +0000 (UTC) Date: Fri, 12 Apr 2019 21:11:00 +0000 (UTC) From: "Dan Ziemba (JIRA)" To: notifications@groovy.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GROOVY-9080) MarkupTemplateEngine uses invalid XML entity for escaping double quotes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-9080?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 16660#comment-16816660 ]=20 Dan Ziemba commented on GROOVY-9080: ------------------------------------ Looks like all that is needed is to fix the 'groovy.text.markup.BaseTemplat= e#escapeQuotes' method. > MarkupTemplateEngine uses invalid XML entity for escaping double quotes > ----------------------------------------------------------------------- > > Key: GROOVY-9080 > URL: https://issues.apache.org/jira/browse/GROOVY-9080 > Project: Groovy > Issue Type: Bug > Components: Templating > Affects Versions: 3.0.0-alpha-4, 2.5.6 > Reporter: Dan Ziemba > Priority: Major > > When MarkupTemplateEngine is used with 'useDoubleQuotes' config enabled, = incorrect output is produced.=C2=A0 > Given this example code: > {code:java} > import groovy.text.markup.* > def out =3D new MarkupTemplateEngine(new TemplateConfiguration(useDoubleQ= uotes: true)) > .createTemplate('''tag(attr: 'contains " quote')''') > .make() > println out > {code} > Result is: > {{}} > But expected result is: > {{}} > The wrong XML entity is used - "e is not valid.=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)