groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [groovy] paulk-asert commented on issue #905: GROOVY-8339: Fix warning "An illegal reflective access operation has …
Date Tue, 16 Apr 2019 03:28:06 GMT
paulk-asert commented on issue #905: GROOVY-8339: Fix warning "An illegal reflective access
operation has …
URL: https://github.com/apache/groovy/pull/905#issuecomment-483497199
 
 
   > > I think some of the functionality in ReflectionUtils might be better in VMPlugin?
Since we already have some similar functionality there?
   > 
   > `ReflectionUtils` provides some facade API for `VMPlugin` , which will make our life
easy IMO ;-)
   
   For me there are two code smells but I don't think either would be hard to fix:
   * Given that VMPlugin is designed to run the correct method for the version of the JVM
we are using, we shouldn't need to also check the version
   * We have some functionality in ReflectionUtils and some similar functionality in VMPlugin
and it's not clear to me that they aren't all at the same level - if that is the case we'd
need to document it that way but I suspect we can consolidate into one level

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message