groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vadimo (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GROOVY-9052) Missing @Generated annotation on @Bindable
Date Thu, 21 Mar 2019 20:28:00 GMT

     [ https://issues.apache.org/jira/browse/GROOVY-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vadimo updated GROOVY-9052:
---------------------------
    Description: 
jacoco is reporting incorrect code coverage results for @Bindable annotated classes. 

The generated 
* set*
* firePropertyChange
* removePropertyChangeListener, 
* addPropertyChangeListener
* getPropertyChangeListener

methods should probably be annotated with @Generated

In the examples below 11 methods that are detected as not covered.
[http://docs.groovy-lang.org/2.5.6/html/gapi/groovy/beans/Bindable.html]
{code:java}
 class Person {
    @groovy.beans.Bindable
    String firstName

    @groovy.beans.Bindable
    def zipCode
 }
{code}


This bug was found during Hackergarten Zürich 

  was:
jacoco is reporting incorrect code coverage results for @Bindable annotated classes. 

The generated internal classes should probably be annotated with @Generated as well as their
default constructor.

In the examples below 11 methods that are detected as not covered.
[http://docs.groovy-lang.org/2.5.6/html/gapi/groovy/beans/Bindable.html]
{code:java}
 class Person {
    @groovy.beans.Bindable
    String firstName

    @groovy.beans.Bindable
    def zipCode
 }
{code}


This bug was found during Hackergarten Zürich 


> Missing @Generated annotation on @Bindable
> ------------------------------------------
>
>                 Key: GROOVY-9052
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9052
>             Project: Groovy
>          Issue Type: Bug
>          Components: Compiler
>    Affects Versions: 2.5.6
>            Reporter: Vadimo
>            Priority: Major
>
> jacoco is reporting incorrect code coverage results for @Bindable annotated classes. 
> The generated 
> * set*
> * firePropertyChange
> * removePropertyChangeListener, 
> * addPropertyChangeListener
> * getPropertyChangeListener
> methods should probably be annotated with @Generated
> In the examples below 11 methods that are detected as not covered.
> [http://docs.groovy-lang.org/2.5.6/html/gapi/groovy/beans/Bindable.html]
> {code:java}
>  class Person {
>     @groovy.beans.Bindable
>     String firstName
>     @groovy.beans.Bindable
>     def zipCode
>  }
> {code}
> This bug was found during Hackergarten Zürich 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message