groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] blackdrag commented on issue #860: Fix non-atomic operation on volatile field 'count'
Date Tue, 05 Feb 2019 01:49:06 GMT
blackdrag commented on issue #860: Fix non-atomic operation on volatile field 'count'
URL: https://github.com/apache/groovy/pull/860#issuecomment-460484213
 
 
   My personal analysis on this is the following.... as long as count is only changed within
a lock/unlock sequence volatile should be good enough. But the rehash methods do not guarantee
that. But then again the implementation would be broken if they do not lock on rehash... actually
I wonder who is actually calling that method.
   
   My conclusion: Get rid of these classes. Java's concurrent hash map provides much better
functionality, much better tested and afaik with a better performance profile. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message